From patchwork Wed Jan 22 09:09:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ong Boon Leong X-Patchwork-Id: 1227126 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 482fkk0RCYz9sPJ for ; Wed, 22 Jan 2020 20:10:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726204AbgAVJKT (ORCPT ); Wed, 22 Jan 2020 04:10:19 -0500 Received: from mga12.intel.com ([192.55.52.136]:54325 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbgAVJKS (ORCPT ); Wed, 22 Jan 2020 04:10:18 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2020 01:10:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,349,1574150400"; d="scan'208";a="244990387" Received: from unknown (HELO bong5-HP-Z440.png.intel.com) ([10.221.118.166]) by orsmga002.jf.intel.com with ESMTP; 22 Jan 2020 01:10:14 -0800 From: Ong Boon Leong To: netdev@vger.kernel.org Cc: Tan Tee Min , Voon Weifeng , Giuseppe Cavallaro , Alexandre TORGUE , Jose Abreu , "David S . Miller" , Maxime Coquelin , Joao Pinto , Arnd Bergmann , Alexandru Ardelean , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net v3 0/5] net: stmmac: general fixes for Ethernet functionality Date: Wed, 22 Jan 2020 17:09:31 +0800 Message-Id: <20200122090936.28555-1-boon.leong.ong@intel.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thanks to all feedbacks from community. We updated the patch-series to below:- 1/5: It ensures that the real_num_rx|tx_queues are set in both driver probe() and resume(). So, move the netif_set_real_num_rx|tx_queues() into stmmac_hw_setup(). Added lock_acquired to allow to decide when to rtnl_lock() & rtnl_unlock() pair:- stmmac_open(): rtnl_lock() & rtnl_unlock() is not needed. stmmac_resume(): rtnl_lock() & rtnl_unlock() is needed. 2/5: It ensures that the previous value of GMAC_VLAN_TAG register is read first before for updating the register. 3/5: It ensures the GMAC IP v4.xx and above behaves correctly to:- ip link set multicast off|on 4/5: Added similar IFF_MULTICAST flag for xgmac2. 5/5: It ensures PCI platform data is using plat->phy_interface. Rgds, Boon Leong Changes from v2:- patch 1/5 - added control for rtnl_lock() & rtnl_unlock() to ensure they are used forstmmac_resume() patch 4/5 - added IFF_MULTICAST flag check for xgmac to ensure multicast works correctly. v1:- - Drop v1 patches (1/7, 3/7 & 4/7) that are not valid. Aashish Verma (1): net: stmmac: Fix incorrect location to set real_num_rx|tx_queues Tan, Tee Min (2): net: stmmac: fix incorrect GMAC_VLAN_TAG register writting in GMAC4+ net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter Verma, Aashish (1): net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter Voon Weifeng (1): net: stmmac: update pci platform data to use phy_interface .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 9 +++++---- .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 19 ++++++++++++------- .../net/ethernet/stmicro/stmmac/stmmac_pci.c | 14 ++++++++------ 4 files changed, 26 insertions(+), 18 deletions(-)