| Message ID | 20191211154755.15012-1-straube.linux@gmail.com |
|---|---|
| Headers | show |
| Series | rtlwifi: convert rtl8192{ce,cu,de} to use generic functions | expand |
On Wed, 2019-12-11 at 16:47 +0100, Michael Straube wrote: > This series converts the drivers rtl8192{ce,cu,de} to use the generic > functions rtl_query_rxpwrpercentage and rtl_signal_scale_mapping. > > Michael Straube (6): > rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage > rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage > rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage > rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping > rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping > rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping > > .../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 48 ++---------------- > .../wireless/realtek/rtlwifi/rtl8192cu/mac.c | 49 ++----------------- > .../wireless/realtek/rtlwifi/rtl8192de/trx.c | 47 ++---------------- > 3 files changed, 14 insertions(+), 130 deletions(-) > For all patches: Acked-by: Ping-Ke Shih <pkshih@realtek.com> Curiously. How can you find these function are identical?
On 2019-12-12 02:47, Pkshih wrote: > On Wed, 2019-12-11 at 16:47 +0100, Michael Straube wrote: >> This series converts the drivers rtl8192{ce,cu,de} to use the generic >> functions rtl_query_rxpwrpercentage and rtl_signal_scale_mapping. >> >> Michael Straube (6): >> rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage >> rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage >> rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage >> rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping >> rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping >> rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping >> >> .../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 48 ++---------------- >> .../wireless/realtek/rtlwifi/rtl8192cu/mac.c | 49 ++----------------- >> .../wireless/realtek/rtlwifi/rtl8192de/trx.c | 47 ++---------------- >> 3 files changed, 14 insertions(+), 130 deletions(-) >> > > For all patches: > Acked-by: Ping-Ke Shih <pkshih@realtek.com> > Thanks. > Curiously. How can you find these function are identical? > While sending cleanup patches for some staging wifi drivers I noticed that these functions are used in many of the realtek drivers and all looked very similar. Then used grep and diff to verify. Michael
This series converts the drivers rtl8192{ce,cu,de} to use the generic functions rtl_query_rxpwrpercentage and rtl_signal_scale_mapping. Michael Straube (6): rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping .../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 48 ++---------------- .../wireless/realtek/rtlwifi/rtl8192cu/mac.c | 49 ++----------------- .../wireless/realtek/rtlwifi/rtl8192de/trx.c | 47 ++---------------- 3 files changed, 14 insertions(+), 130 deletions(-)