mbox series

[net-next,v3,0/2] net: dsa: mv88e6xxx: Add support for port mirroring

Message ID 20191107211114.106310-1-irtimmer@gmail.com
Headers show
Series net: dsa: mv88e6xxx: Add support for port mirroring | expand

Message

Iwan R Timmer Nov. 7, 2019, 9:11 p.m. UTC
This patch serie add support for port mirroring in the mv88e6xx switch driver.
The first patch changes the set_egress_port function to allow different egress
ports for egress and ingress traffic. The second patch adds the actual code for
port mirroring support.

Tested on a 88E6176 with:

tc qdisc add dev wan0 clsact
tc filter add dev wan0 ingress matchall skip_sw \
        action mirred egress mirror dev lan2
tc filter add dev wan0 egress matchall skip_sw \
        action mirred egress mirror dev lan3

Changes in v3

- Use enum for egress traffic direction
- Keep track of egress ports on mv88e6390
- Move booleans in struct for better structure packing

Changes in v2

- Support mirroring egress and ingress traffic to different ports
- Check for invalid configurations when multiple ports are mirrored

Iwan R Timmer (2):
  net: dsa: mv88e6xxx: Split monitor port configuration
  net: dsa: mv88e6xxx: Add support for port mirroring

 drivers/net/dsa/mv88e6xxx/chip.c    | 85 ++++++++++++++++++++++++++++-
 drivers/net/dsa/mv88e6xxx/chip.h    | 15 ++++-
 drivers/net/dsa/mv88e6xxx/global1.c | 60 ++++++++++++++------
 drivers/net/dsa/mv88e6xxx/global1.h |  8 ++-
 drivers/net/dsa/mv88e6xxx/port.c    | 37 +++++++++++++
 drivers/net/dsa/mv88e6xxx/port.h    |  3 +
 6 files changed, 188 insertions(+), 20 deletions(-)

Comments

David Miller Nov. 11, 2019, 8:51 p.m. UTC | #1
From: Iwan R Timmer <irtimmer@gmail.com>
Date: Thu,  7 Nov 2019 22:11:12 +0100

> This patch serie add support for port mirroring in the mv88e6xx switch driver.
              ^^^^ corrected to "series"
> The first patch changes the set_egress_port function to allow different egress
> ports for egress and ingress traffic. The second patch adds the actual code for
> port mirroring support.
> 
> Tested on a 88E6176 with:
> 
> tc qdisc add dev wan0 clsact
> tc filter add dev wan0 ingress matchall skip_sw \
>         action mirred egress mirror dev lan2
> tc filter add dev wan0 egress matchall skip_sw \
>         action mirred egress mirror dev lan3

Series applied with the reverse christmas tree problems fixed in
patch #2.

Thanks.