mbox series

[bpf-next,0/2] test_bpf: Add an skb_segment test for a linear head_frag=0 skb whose gso_size was mangled

Message ID 20191025134223.2761-1-shmulik.ladkani@gmail.com
Headers show
Series test_bpf: Add an skb_segment test for a linear head_frag=0 skb whose gso_size was mangled | expand

Message

Shmulik Ladkani Oct. 25, 2019, 1:42 p.m. UTC 
Add a reproducer test that mimics the input skbs that lead to the BUG_ON
in skb_segment() which was fixed by commit 3dcbdb134f32 ("net: gso: Fix skb_segment splat when splitting gso_size mangled skb having linear-headed frag_list").

Shmulik Ladkani (2):
  test_bpf: Refactor test_skb_segment() to allow testing skb_segment()
    on numerous different skbs
  test_bpf: Introduce 'gso_linear_no_head_frag' skb_segment test

 lib/test_bpf.c | 112 +++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 103 insertions(+), 9 deletions(-)

Comments

Daniel Borkmann Oct. 30, 2019, 3:56 p.m. UTC | #1 
On Fri, Oct 25, 2019 at 04:42:21PM +0300, Shmulik Ladkani wrote:
> Add a reproducer test that mimics the input skbs that lead to the BUG_ON
> in skb_segment() which was fixed by commit 3dcbdb134f32 ("net: gso: Fix skb_segment splat when splitting gso_size mangled skb having linear-headed frag_list").
> 
> Shmulik Ladkani (2):
>   test_bpf: Refactor test_skb_segment() to allow testing skb_segment()
>     on numerous different skbs
>   test_bpf: Introduce 'gso_linear_no_head_frag' skb_segment test
> 
>  lib/test_bpf.c | 112 +++++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 103 insertions(+), 9 deletions(-)

Applied, thanks!