| Message ID | 20190825194630.12404-1-olteanv@gmail.com |
|---|---|
| Headers | show |
| Series | Simplify DSA handling of VLAN subinterface offload | expand |
From: Vladimir Oltean <olteanv@gmail.com> Date: Sun, 25 Aug 2019 22:46:28 +0300 > Depends on Vivien Didelot's patchset: > https://patchwork.ozlabs.org/project/netdev/list/?series=127197&state=* > > This patchset removes a few strange-looking guards for -EOPNOTSUPP in > dsa_slave_vlan_rx_add_vid and dsa_slave_vlan_rx_kill_vid, making that > code path no longer possible. > > It also disables the code path for the sja1105 driver, which does > support editing the VLAN table, but not hardware-accelerated VLAN > sub-interfaces, therefore the check in the DSA core would be wrong. > There was no better DSA callback to do this than .port_enable, i.e. > at ndo_open time. Series applied.
Depends on Vivien Didelot's patchset: https://patchwork.ozlabs.org/project/netdev/list/?series=127197&state=* This patchset removes a few strange-looking guards for -EOPNOTSUPP in dsa_slave_vlan_rx_add_vid and dsa_slave_vlan_rx_kill_vid, making that code path no longer possible. It also disables the code path for the sja1105 driver, which does support editing the VLAN table, but not hardware-accelerated VLAN sub-interfaces, therefore the check in the DSA core would be wrong. There was no better DSA callback to do this than .port_enable, i.e. at ndo_open time. Vladimir Oltean (2): net: dsa: Advertise the VLAN offload netdev ability only if switch supports it net: dsa: sja1105: Clear VLAN filtering offload netdev feature drivers/net/dsa/sja1105/sja1105_main.c | 16 ++++++++++++++++ net/dsa/slave.c | 15 ++++++--------- 2 files changed, 22 insertions(+), 9 deletions(-)