mbox series

[bpf-next,v2,0/2] net: xdp: refactor the XDP_QUERY_PROG and XDP_QUERY_PROG_HW code

Message ID 20190531094215.3729-1-bjorn.topel@gmail.com
Headers show
Series net: xdp: refactor the XDP_QUERY_PROG and XDP_QUERY_PROG_HW code | expand

Message

Björn Töpel May 31, 2019, 9:42 a.m. UTC
Here's yet another attempt tomove the XDP_QUERY_PROG{,_HW} code out
from the drivers to generic netdev code.

The first patch in the series move the XDP query functionality, and
the second remove XDP_QUERY_PROG{,_HW} from all drivers.

Please refer to the individual commit messages for more details.

The patch passes test_offload.py from selftests. Thanks to Jakub for
pointing this out.

I, hopefully, addressed all comments from Jakub and Saeed, except one;
I did not move the XDP struct net_device into a struct of its own.


Thanks,
Björn


Björn Töpel (2):
  net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev
  net: xdp: remove XDP_QUERY_PROG{,_HW}

 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c |   4 -
 .../net/ethernet/cavium/thunder/nicvf_main.c  |   3 -
 .../net/ethernet/freescale/dpaa2/dpaa2-eth.c  |   3 -
 drivers/net/ethernet/intel/i40e/i40e_main.c   |   3 -
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |   4 -
 .../net/ethernet/intel/ixgbevf/ixgbevf_main.c |   4 -
 .../net/ethernet/mellanox/mlx4/en_netdev.c    |  24 ---
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  18 ---
 .../ethernet/netronome/nfp/nfp_net_common.c   |   4 -
 .../net/ethernet/qlogic/qede/qede_filter.c    |   3 -
 drivers/net/netdevsim/bpf.c                   |   4 -
 drivers/net/netdevsim/netdevsim.h             |   2 +-
 drivers/net/tun.c                             |  15 --
 drivers/net/veth.c                            |  15 --
 drivers/net/virtio_net.c                      |  17 ---
 include/linux/netdevice.h                     |  23 ++-
 include/net/xdp.h                             |   6 +-
 net/core/dev.c                                | 143 +++++++++++-------
 net/core/rtnetlink.c                          |  53 ++++---
 net/core/xdp.c                                |  20 ++-
 20 files changed, 137 insertions(+), 231 deletions(-)

Comments

Björn Töpel May 31, 2019, 9:45 a.m. UTC | #1
On Fri, 31 May 2019 at 11:42, Björn Töpel <bjorn.topel@gmail.com> wrote:
>
[...]
>
> I, hopefully, addressed all comments from Jakub and Saeed, except one;
> I did not move the XDP struct net_device into a struct of its own.
>

Uhm, the last sentence was weird.

What I meant was: I did not move the newly introduced XDP members
(flags/hw prog) into a struct of its own.