mbox series

[v2,bpf-next,0/3] bpf: optimize explored_states

Message ID 20190522031707.2834254-1-ast@kernel.org
Headers show
Series bpf: optimize explored_states | expand

Message

Alexei Starovoitov May 22, 2019, 3:17 a.m. UTC 
Convert explored_states array into hash table and use simple hash to
reduce verifier peak memory consumption for programs with bpf2bpf calls.
More details in patch 3.

v1->v2: fixed Jakub's small nit in patch 1

Alexei Starovoitov (3):
  bpf: cleanup explored_states
  bpf: split explored_states
  bpf: convert explored_states to hash table

 include/linux/bpf_verifier.h |  2 +
 kernel/bpf/verifier.c        | 77 ++++++++++++++++++++++--------------
 2 files changed, 50 insertions(+), 29 deletions(-)

Comments

Andrii Nakryiko May 22, 2019, 5:54 a.m. UTC | #1 
On Tue, May 21, 2019 at 8:17 PM Alexei Starovoitov <ast@kernel.org> wrote:
>
> Convert explored_states array into hash table and use simple hash to
> reduce verifier peak memory consumption for programs with bpf2bpf calls.
> More details in patch 3.
>
> v1->v2: fixed Jakub's small nit in patch 1
>
> Alexei Starovoitov (3):
>   bpf: cleanup explored_states
>   bpf: split explored_states
>   bpf: convert explored_states to hash table
>
>  include/linux/bpf_verifier.h |  2 +
>  kernel/bpf/verifier.c        | 77 ++++++++++++++++++++++--------------
>  2 files changed, 50 insertions(+), 29 deletions(-)
>
> --
> 2.20.0
>

For the series:

Acked-by: Andrii Nakryiko <andriin@fb.com>
Daniel Borkmann May 24, 2019, 8:05 a.m. UTC | #2 
On 05/22/2019 05:17 AM, Alexei Starovoitov wrote:
> Convert explored_states array into hash table and use simple hash to
> reduce verifier peak memory consumption for programs with bpf2bpf calls.
> More details in patch 3.
> 
> v1->v2: fixed Jakub's small nit in patch 1
> 
> Alexei Starovoitov (3):
>   bpf: cleanup explored_states
>   bpf: split explored_states
>   bpf: convert explored_states to hash table
> 
>  include/linux/bpf_verifier.h |  2 +
>  kernel/bpf/verifier.c        | 77 ++++++++++++++++++++++--------------
>  2 files changed, 50 insertions(+), 29 deletions(-)
> 

Applied, thanks!