mbox series

[net-next,v4,00/12] net: call for phys_port_name into devlink directly if possible

Message ID 20190328125646.872-1-jiri@resnulli.us
Headers show
Series net: call for phys_port_name into devlink directly if possible | expand

Message

Jiri Pirko March 28, 2019, 12:56 p.m. UTC 
From: Jiri Pirko <jiri@mellanox.com>

phys_port_name may be assembled by a helper in devlink. It is currently
the case only for mlxsw driver. Benefit from the get_devlink_port ndo
and call into devlink directly from dev_get_phys_port_name(). That saves
the trip to the driver, simplifies the code and makes it similar to
recently introduced ethtool-devlink compat helpers.

Move bnxt, partly nfp and dsa to let devlink core generate the name too.

Jiri Pirko (12):
  nfp: register devlink port before netdev
  net: replace ndo_get_devlink with ndo_get_devlink_port
  net: devlink: introduce devlink_compat_phys_port_name_get()
  mlxsw: Implement ndo_get_devlink_port
  mlxsw: Remove ndo_get_phys_port_name implementation
  net: devlink: remove unused devlink_port_get_phys_port_name() function
  bnxt: implement ndo_get_devlink_port
  bnxt: remove ndo_get_phys_port_name implementation
  dsa: implement ndo_get_devlink_port
  dsa: do not support ndo_get_phys_port_name for non-legacy ports
  nfp: do not handle nn->port defined case in
    nfp_net_get_phys_port_name()
  net: devlink: add warning for ndo_get_phys_port_name set when not
    needed

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 26 ++++--------
 drivers/net/ethernet/mellanox/mlxsw/core.c    | 10 +++--
 drivers/net/ethernet/mellanox/mlxsw/core.h    |  5 ++-
 drivers/net/ethernet/mellanox/mlxsw/minimal.c | 22 +++++-----
 .../net/ethernet/mellanox/mlxsw/spectrum.c    | 22 +++++-----
 .../net/ethernet/mellanox/mlxsw/switchx2.c    | 22 +++++-----
 drivers/net/ethernet/netronome/nfp/nfp_app.h  |  2 +-
 .../net/ethernet/netronome/nfp/nfp_devlink.c  | 10 ++---
 .../ethernet/netronome/nfp/nfp_net_common.c   |  7 +++-
 .../net/ethernet/netronome/nfp/nfp_net_main.c | 32 ++++++++-------
 .../net/ethernet/netronome/nfp/nfp_net_repr.c |  2 +-
 include/linux/netdevice.h                     |  6 +--
 include/net/devlink.h                         | 25 +++++++++--
 net/core/dev.c                                | 11 +++--
 net/core/devlink.c                            | 41 +++++++++++++++++--
 net/dsa/slave.c                               | 15 +++++++
 16 files changed, 164 insertions(+), 94 deletions(-)

Comments

David Miller March 28, 2019, 7:56 p.m. UTC | #1 
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 28 Mar 2019 13:56:34 +0100

> From: Jiri Pirko <jiri@mellanox.com>
> 
> phys_port_name may be assembled by a helper in devlink. It is currently
> the case only for mlxsw driver. Benefit from the get_devlink_port ndo
> and call into devlink directly from dev_get_phys_port_name(). That saves
> the trip to the driver, simplifies the code and makes it similar to
> recently introduced ethtool-devlink compat helpers.
> 
> Move bnxt, partly nfp and dsa to let devlink core generate the name too.

Series applied, thanks Jiri.