| Message ID | 20190214182754.30721-1-dmurphy@ti.com |
|---|---|
| Headers | show |
| Series | M_CAN Framework re-write | expand |
Bump On 2/14/19 12:27 PM, Dan Murphy wrote: > Hello > > OK I did not give up on this patch series just got a little preoccupied with > some other kernel work. But here is the update per the comments. > > It should be understood I broke these out for reviewability. > For instance the first patch does not compile on its own as including this > patch should not change the current functionality and it pulls all the io-mapped > code from the m_can base file to a platfrom file. > > The next patch "Migrate the m_can code to use the framework" > is the change to the kernel for the io-mapped conversion from a flat file to use > the framework. Finally the rename patch just renames the m_can_priv to > m_can_classdev. I broke this change out specifically for readability of the > migration patch per comments on the code. > > AFAIC the first 3 patches can all be squashed into a single patch. Or the > first 2 patches in the series can be re-arranged but then m_can functionality is > affected in the migration patch. > > Again the first 3 patches here are all just for readability and review purposes. > > Dan > > Dan Murphy (5): > can: m_can: Create a m_can platform framework > can: m_can: Migrate the m_can code to use the framework > can: m_can: Rename m_can_priv to m_can_classdev > dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver > can: tcan4x5x: Add tcan4x5x driver to the kernel > > .../devicetree/bindings/net/can/tcan4x5x.txt | 37 + > drivers/net/can/m_can/Kconfig | 14 +- > drivers/net/can/m_can/Makefile | 2 + > drivers/net/can/m_can/m_can.c | 788 +++++++++--------- > drivers/net/can/m_can/m_can.h | 159 ++++ > drivers/net/can/m_can/m_can_platform.c | 198 +++++ > drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++ > 7 files changed, 1320 insertions(+), 409 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt > create mode 100644 drivers/net/can/m_can/m_can.h > create mode 100644 drivers/net/can/m_can/m_can_platform.c > create mode 100644 drivers/net/can/m_can/tcan4x5x.c >
Hello Dan, I will have a closer look end of this week! Wolfgang. Am 21.02.19 um 17:24 schrieb Dan Murphy: > Bump > > On 2/14/19 12:27 PM, Dan Murphy wrote: >> Hello >> >> OK I did not give up on this patch series just got a little preoccupied with >> some other kernel work. But here is the update per the comments. >> >> It should be understood I broke these out for reviewability. >> For instance the first patch does not compile on its own as including this >> patch should not change the current functionality and it pulls all the io-mapped >> code from the m_can base file to a platfrom file. >> >> The next patch "Migrate the m_can code to use the framework" >> is the change to the kernel for the io-mapped conversion from a flat file to use >> the framework. Finally the rename patch just renames the m_can_priv to >> m_can_classdev. I broke this change out specifically for readability of the >> migration patch per comments on the code. >> >> AFAIC the first 3 patches can all be squashed into a single patch. Or the >> first 2 patches in the series can be re-arranged but then m_can functionality is >> affected in the migration patch. >> >> Again the first 3 patches here are all just for readability and review purposes. >> >> Dan >> >> Dan Murphy (5): >> can: m_can: Create a m_can platform framework >> can: m_can: Migrate the m_can code to use the framework >> can: m_can: Rename m_can_priv to m_can_classdev >> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >> can: tcan4x5x: Add tcan4x5x driver to the kernel >> >> .../devicetree/bindings/net/can/tcan4x5x.txt | 37 + >> drivers/net/can/m_can/Kconfig | 14 +- >> drivers/net/can/m_can/Makefile | 2 + >> drivers/net/can/m_can/m_can.c | 788 +++++++++--------- >> drivers/net/can/m_can/m_can.h | 159 ++++ >> drivers/net/can/m_can/m_can_platform.c | 198 +++++ >> drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++ >> 7 files changed, 1320 insertions(+), 409 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >> create mode 100644 drivers/net/can/m_can/m_can.h >> create mode 100644 drivers/net/can/m_can/m_can_platform.c >> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >> > >
Hello Dan, what kernel version is that patch series for. I have problems to apply it! Wolfgang. Am 21.02.19 um 17:41 schrieb Wolfgang Grandegger: > Hello Dan, > > I will have a closer look end of this week! > > Wolfgang. > > Am 21.02.19 um 17:24 schrieb Dan Murphy: >> Bump >> >> On 2/14/19 12:27 PM, Dan Murphy wrote: >>> Hello >>> >>> OK I did not give up on this patch series just got a little preoccupied with >>> some other kernel work. But here is the update per the comments. >>> >>> It should be understood I broke these out for reviewability. >>> For instance the first patch does not compile on its own as including this >>> patch should not change the current functionality and it pulls all the io-mapped >>> code from the m_can base file to a platfrom file. >>> >>> The next patch "Migrate the m_can code to use the framework" >>> is the change to the kernel for the io-mapped conversion from a flat file to use >>> the framework. Finally the rename patch just renames the m_can_priv to >>> m_can_classdev. I broke this change out specifically for readability of the >>> migration patch per comments on the code. >>> >>> AFAIC the first 3 patches can all be squashed into a single patch. Or the >>> first 2 patches in the series can be re-arranged but then m_can functionality is >>> affected in the migration patch. >>> >>> Again the first 3 patches here are all just for readability and review purposes. >>> >>> Dan >>> >>> Dan Murphy (5): >>> can: m_can: Create a m_can platform framework >>> can: m_can: Migrate the m_can code to use the framework >>> can: m_can: Rename m_can_priv to m_can_classdev >>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >>> can: tcan4x5x: Add tcan4x5x driver to the kernel >>> >>> .../devicetree/bindings/net/can/tcan4x5x.txt | 37 + >>> drivers/net/can/m_can/Kconfig | 14 +- >>> drivers/net/can/m_can/Makefile | 2 + >>> drivers/net/can/m_can/m_can.c | 788 +++++++++--------- >>> drivers/net/can/m_can/m_can.h | 159 ++++ >>> drivers/net/can/m_can/m_can_platform.c | 198 +++++ >>> drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++ >>> 7 files changed, 1320 insertions(+), 409 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>> create mode 100644 drivers/net/can/m_can/m_can.h >>> create mode 100644 drivers/net/can/m_can/m_can_platform.c >>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >>> >> >>
Wolfgang On 2/22/19 3:38 AM, Wolfgang Grandegger wrote: > Hello Dan, > > what kernel version is that patch series for. I have problems to apply it! > It is based off of Master commit 2137397c92aec3713fa10be3c9b830f9a1674e60 (linux_master/master) And I successfully rebased on top of commit 8a61716ff2ab23eddd1f7a05a075a374e4d0c3d4 (linux_master/master) Merge tag 'ceph-for-5.0-rc8' of git://github.com/ceph/ceph-client Dan > Wolfgang. > > Am 21.02.19 um 17:41 schrieb Wolfgang Grandegger: >> Hello Dan, >> >> I will have a closer look end of this week! >> >> Wolfgang. >> >> Am 21.02.19 um 17:24 schrieb Dan Murphy: >>> Bump >>> >>> On 2/14/19 12:27 PM, Dan Murphy wrote: >>>> Hello >>>> >>>> OK I did not give up on this patch series just got a little preoccupied with >>>> some other kernel work. But here is the update per the comments. >>>> >>>> It should be understood I broke these out for reviewability. >>>> For instance the first patch does not compile on its own as including this >>>> patch should not change the current functionality and it pulls all the io-mapped >>>> code from the m_can base file to a platfrom file. >>>> >>>> The next patch "Migrate the m_can code to use the framework" >>>> is the change to the kernel for the io-mapped conversion from a flat file to use >>>> the framework. Finally the rename patch just renames the m_can_priv to >>>> m_can_classdev. I broke this change out specifically for readability of the >>>> migration patch per comments on the code. >>>> >>>> AFAIC the first 3 patches can all be squashed into a single patch. Or the >>>> first 2 patches in the series can be re-arranged but then m_can functionality is >>>> affected in the migration patch. >>>> >>>> Again the first 3 patches here are all just for readability and review purposes. >>>> >>>> Dan >>>> >>>> Dan Murphy (5): >>>> can: m_can: Create a m_can platform framework >>>> can: m_can: Migrate the m_can code to use the framework >>>> can: m_can: Rename m_can_priv to m_can_classdev >>>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >>>> can: tcan4x5x: Add tcan4x5x driver to the kernel >>>> >>>> .../devicetree/bindings/net/can/tcan4x5x.txt | 37 + >>>> drivers/net/can/m_can/Kconfig | 14 +- >>>> drivers/net/can/m_can/Makefile | 2 + >>>> drivers/net/can/m_can/m_can.c | 788 +++++++++--------- >>>> drivers/net/can/m_can/m_can.h | 159 ++++ >>>> drivers/net/can/m_can/m_can_platform.c | 198 +++++ >>>> drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++ >>>> 7 files changed, 1320 insertions(+), 409 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>>> create mode 100644 drivers/net/can/m_can/m_can.h >>>> create mode 100644 drivers/net/can/m_can/m_can_platform.c >>>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >>>> >>> >>>
Wolfgang On 2/22/19 6:50 AM, Dan Murphy wrote: > Wolfgang > > On 2/22/19 3:38 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> what kernel version is that patch series for. I have problems to apply it! >> > > It is based off of Master > > commit 2137397c92aec3713fa10be3c9b830f9a1674e60 (linux_master/master) > > And I successfully rebased on top of > > commit 8a61716ff2ab23eddd1f7a05a075a374e4d0c3d4 (linux_master/master) > Merge tag 'ceph-for-5.0-rc8' of git://github.com/ceph/ceph-client > I just pulled these patches and they applied fine to the top commit of linux master Do I need to rebase on top of a for-next branch for you? Dan > Dan > >> Wolfgang. >> >> Am 21.02.19 um 17:41 schrieb Wolfgang Grandegger: >>> Hello Dan, >>> >>> I will have a closer look end of this week! >>> >>> Wolfgang. >>> >>> Am 21.02.19 um 17:24 schrieb Dan Murphy: >>>> Bump >>>> >>>> On 2/14/19 12:27 PM, Dan Murphy wrote: >>>>> Hello >>>>> >>>>> OK I did not give up on this patch series just got a little preoccupied with >>>>> some other kernel work. But here is the update per the comments. >>>>> >>>>> It should be understood I broke these out for reviewability. >>>>> For instance the first patch does not compile on its own as including this >>>>> patch should not change the current functionality and it pulls all the io-mapped >>>>> code from the m_can base file to a platfrom file. >>>>> >>>>> The next patch "Migrate the m_can code to use the framework" >>>>> is the change to the kernel for the io-mapped conversion from a flat file to use >>>>> the framework. Finally the rename patch just renames the m_can_priv to >>>>> m_can_classdev. I broke this change out specifically for readability of the >>>>> migration patch per comments on the code. >>>>> >>>>> AFAIC the first 3 patches can all be squashed into a single patch. Or the >>>>> first 2 patches in the series can be re-arranged but then m_can functionality is >>>>> affected in the migration patch. >>>>> >>>>> Again the first 3 patches here are all just for readability and review purposes. >>>>> >>>>> Dan >>>>> >>>>> Dan Murphy (5): >>>>> can: m_can: Create a m_can platform framework >>>>> can: m_can: Migrate the m_can code to use the framework >>>>> can: m_can: Rename m_can_priv to m_can_classdev >>>>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >>>>> can: tcan4x5x: Add tcan4x5x driver to the kernel >>>>> >>>>> .../devicetree/bindings/net/can/tcan4x5x.txt | 37 + >>>>> drivers/net/can/m_can/Kconfig | 14 +- >>>>> drivers/net/can/m_can/Makefile | 2 + >>>>> drivers/net/can/m_can/m_can.c | 788 +++++++++--------- >>>>> drivers/net/can/m_can/m_can.h | 159 ++++ >>>>> drivers/net/can/m_can/m_can_platform.c | 198 +++++ >>>>> drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++ >>>>> 7 files changed, 1320 insertions(+), 409 deletions(-) >>>>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>>>> create mode 100644 drivers/net/can/m_can/m_can.h >>>>> create mode 100644 drivers/net/can/m_can/m_can_platform.c >>>>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >>>>> >>>> >>>> > >
Hello Dan, Am 22.02.19 um 18:05 schrieb Dan Murphy: > Wolfgang > > On 2/22/19 6:50 AM, Dan Murphy wrote: >> Wolfgang >> >> On 2/22/19 3:38 AM, Wolfgang Grandegger wrote: >>> Hello Dan, >>> >>> what kernel version is that patch series for. I have problems to apply it! >>> >> >> It is based off of Master >> >> commit 2137397c92aec3713fa10be3c9b830f9a1674e60 (linux_master/master) >> >> And I successfully rebased on top of >> >> commit 8a61716ff2ab23eddd1f7a05a075a374e4d0c3d4 (linux_master/master) >> Merge tag 'ceph-for-5.0-rc8' of git://github.com/ceph/ceph-client >> > > I just pulled these patches and they applied fine to the top commit of linux master > > Do I need to rebase on top of a for-next branch for you? No, I can apply the series now as well. Wolfgang,
Wolfgang On 2/24/19 5:27 AM, Wolfgang Grandegger wrote: > Hello Dan, > > Am 22.02.19 um 18:05 schrieb Dan Murphy: >> Wolfgang >> >> On 2/22/19 6:50 AM, Dan Murphy wrote: >>> Wolfgang >>> >>> On 2/22/19 3:38 AM, Wolfgang Grandegger wrote: >>>> Hello Dan, >>>> >>>> what kernel version is that patch series for. I have problems to apply it! >>>> >>> >>> It is based off of Master >>> >>> commit 2137397c92aec3713fa10be3c9b830f9a1674e60 (linux_master/master) >>> >>> And I successfully rebased on top of >>> >>> commit 8a61716ff2ab23eddd1f7a05a075a374e4d0c3d4 (linux_master/master) >>> Merge tag 'ceph-for-5.0-rc8' of git://github.com/ceph/ceph-client >>> >> >> I just pulled these patches and they applied fine to the top commit of linux master >> >> Do I need to rebase on top of a for-next branch for you? > > No, I can apply the series now as well. > Good. Just commenting to bump this in my email list. Waiting on comments. Dan > Wolfgang, >
Hello, Am 14.02.19 um 19:27 schrieb Dan Murphy: > Hello > > OK I did not give up on this patch series just got a little preoccupied with > some other kernel work. But here is the update per the comments. > > It should be understood I broke these out for reviewability. > For instance the first patch does not compile on its own as including this > patch should not change the current functionality and it pulls all the io-mapped > code from the m_can base file to a platfrom file. For git bisection, the code must compile! > The next patch "Migrate the m_can code to use the framework" > is the change to the kernel for the io-mapped conversion from a flat file to use > the framework. Finally the rename patch just renames the m_can_priv to > m_can_classdev. I broke this change out specifically for readability of the > migration patch per comments on the code. > > AFAIC the first 3 patches can all be squashed into a single patch. Or the > first 2 patches in the series can be re-arranged but then m_can functionality is > affected in the migration patch. For the reason above, I would squash patch 1 and 2. > > Again the first 3 patches here are all just for readability and review purposes.> > Dan > > Dan Murphy (5): > can: m_can: Create a m_can platform framework > can: m_can: Migrate the m_can code to use the framework > can: m_can: Rename m_can_priv to m_can_classdev > dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver > can: tcan4x5x: Add tcan4x5x driver to the kernel > > .../devicetree/bindings/net/can/tcan4x5x.txt | 37 + > drivers/net/can/m_can/Kconfig | 14 +- > drivers/net/can/m_can/Makefile | 2 + > drivers/net/can/m_can/m_can.c | 788 +++++++++--------- > drivers/net/can/m_can/m_can.h | 159 ++++ > drivers/net/can/m_can/m_can_platform.c | 198 +++++ > drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++ > 7 files changed, 1320 insertions(+), 409 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt > create mode 100644 drivers/net/can/m_can/m_can.h > create mode 100644 drivers/net/can/m_can/m_can_platform.c > create mode 100644 drivers/net/can/m_can/tcan4x5x.c There are plenty of coding-style errors, e.g. white-space, indention, line too long, etc. Please use "checkpatch" to find and fix. Wolfgang.
Wolfgang On 2/28/19 10:40 AM, Wolfgang Grandegger wrote: > Hello, > > Am 14.02.19 um 19:27 schrieb Dan Murphy: >> Hello >> >> OK I did not give up on this patch series just got a little preoccupied with >> some other kernel work. But here is the update per the comments. >> >> It should be understood I broke these out for reviewability. >> For instance the first patch does not compile on its own as including this >> patch should not change the current functionality and it pulls all the io-mapped >> code from the m_can base file to a platfrom file. > > For git bisection, the code must compile! > So I can squash patch 1 and 2 then. >> The next patch "Migrate the m_can code to use the framework" >> is the change to the kernel for the io-mapped conversion from a flat file to use >> the framework. Finally the rename patch just renames the m_can_priv to >> m_can_classdev. I broke this change out specifically for readability of the >> migration patch per comments on the code. >> >> AFAIC the first 3 patches can all be squashed into a single patch. Or the >> first 2 patches in the series can be re-arranged but then m_can functionality is >> affected in the migration patch. > > For the reason above, I would squash patch 1 and 2. > >> >> Again the first 3 patches here are all just for readability and review purposes.> >> Dan >> >> Dan Murphy (5): >> can: m_can: Create a m_can platform framework >> can: m_can: Migrate the m_can code to use the framework >> can: m_can: Rename m_can_priv to m_can_classdev >> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >> can: tcan4x5x: Add tcan4x5x driver to the kernel >> >> .../devicetree/bindings/net/can/tcan4x5x.txt | 37 + >> drivers/net/can/m_can/Kconfig | 14 +- >> drivers/net/can/m_can/Makefile | 2 + >> drivers/net/can/m_can/m_can.c | 788 +++++++++--------- >> drivers/net/can/m_can/m_can.h | 159 ++++ >> drivers/net/can/m_can/m_can_platform.c | 198 +++++ >> drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++ >> 7 files changed, 1320 insertions(+), 409 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >> create mode 100644 drivers/net/can/m_can/m_can.h >> create mode 100644 drivers/net/can/m_can/m_can_platform.c >> create mode 100644 drivers/net/can/m_can/tcan4x5x.c > > There are plenty of coding-style errors, e.g. white-space, indention, > line too long, etc. Please use "checkpatch" to find and fix. > Ack. I missed running it on v5. I will update in v6. > Wolfgang. > > >