Message ID | 20190107194733.31138-1-toke@toke.dk |
---|---|
Headers | show |
Series | sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc | expand |
From: Toke Høiland-Jørgensen <toke@toke.dk> Date: Mon, 7 Jan 2019 20:47:29 +0100 > This series fixes a couple of issues exposed by running sch_cake as a > leaf qdisc in an HFSC tree, which were discovered and reported by Pete > Heist. The interaction between CAKE's GSO splitting and the parent > qdisc's notion of its own queue length could cause queue stalls. While > investigating the report, I also noticed that several qdiscs would > dereference the skb pointer after dequeue, which is potentially > problematic since the GSO splitting code also frees the original skb. > > See the individual patches in the series for details. Toke, can you please resubmit this without patch #3. If you want to push for patch #3 still, it is much easier to submit it separately.
David Miller <davem@davemloft.net> writes: > From: Toke Høiland-Jørgensen <toke@toke.dk> > Date: Mon, 7 Jan 2019 20:47:29 +0100 > >> This series fixes a couple of issues exposed by running sch_cake as a >> leaf qdisc in an HFSC tree, which were discovered and reported by Pete >> Heist. The interaction between CAKE's GSO splitting and the parent >> qdisc's notion of its own queue length could cause queue stalls. While >> investigating the report, I also noticed that several qdiscs would >> dereference the skb pointer after dequeue, which is potentially >> problematic since the GSO splitting code also frees the original skb. >> >> See the individual patches in the series for details. > > Toke, can you please resubmit this without patch #3. > > If you want to push for patch #3 still, it is much easier to submit > it separately. Can do :) -Toke