mbox series

[v2,net-next,0/5] tcp: add 4 new stats

Message ID 20180801004624.154346-1-tracywwnj@gmail.com
Headers show
Series tcp: add 4 new stats | expand

Message

Wei Wang Aug. 1, 2018, 12:46 a.m. UTC
From: Wei Wang <weiwan@google.com>

This patch series adds 3 RFC4898 stats:
1. tcpEStatsPerfHCDataOctetsOut
2. tcpEStatsPerfOctetsRetrans
3. tcpEStatsStackDSACKDups
and an addtional stat to record the number of data packet reordering
events seen:
4. tcp_reord_seen

Together with the existing stats, application can use them to measure
the retransmission rate in bytes, exclude spurious retransmissions
reflected by DSACK, and keep track of the reordering events on live
connections.
In particular the networks with different MTUs make bytes-based loss stats
more useful. Google servers have been using these stats for many years to
instrument transport and network performance.

Note: The first patch is a refactor to add a helper to calculate
opt_stats size in order to make later changes cleaner.

Wei Wang (5):
  tcp: add a helper to calculate size of opt_stats
  tcp: add data bytes sent stats
  tcp: add data bytes retransmitted stats
  tcp: add dsack blocks received stats
  tcp: add stat of data packet reordering events

 include/linux/tcp.h      | 13 ++++++++++--
 include/uapi/linux/tcp.h | 10 ++++++++-
 net/ipv4/tcp.c           | 46 +++++++++++++++++++++++++++++++++++++---
 net/ipv4/tcp_input.c     |  4 +++-
 net/ipv4/tcp_output.c    |  2 ++
 net/ipv4/tcp_recovery.c  |  2 +-
 6 files changed, 69 insertions(+), 8 deletions(-)

Comments

David Miller Aug. 1, 2018, 4:56 p.m. UTC | #1
From: Wei Wang <weiwan@google.com>
Date: Tue, 31 Jul 2018 17:46:19 -0700

> From: Wei Wang <weiwan@google.com>
> 
> This patch series adds 3 RFC4898 stats:
> 1. tcpEStatsPerfHCDataOctetsOut
> 2. tcpEStatsPerfOctetsRetrans
> 3. tcpEStatsStackDSACKDups
> and an addtional stat to record the number of data packet reordering
> events seen:
> 4. tcp_reord_seen
> 
> Together with the existing stats, application can use them to measure
> the retransmission rate in bytes, exclude spurious retransmissions
> reflected by DSACK, and keep track of the reordering events on live
> connections.
> In particular the networks with different MTUs make bytes-based loss stats
> more useful. Google servers have been using these stats for many years to
> instrument transport and network performance.
> 
> Note: The first patch is a refactor to add a helper to calculate
> opt_stats size in order to make later changes cleaner.

Series applied, thank you.