| Message ID | 20180605122851.23912-1-yuehaibing@huawei.com |
|---|---|
| Headers | show |
| Series | use pci_zalloc_consistent | expand |
On Tue, Jun 5, 2018 at 3:28 PM, YueHaibing <yuehaibing@huawei.com> wrote: > Hmm... Is PCI case anyhow special or it's a simple wrapper on top of dma.*alloc() ? > YueHaibing (6): > net: hippi: use pci_zalloc_consistent > net: atheros: use pci_zalloc_consistent > net: neterion: use pci_zalloc_consistent > netxen_nic: use pci_zalloc_consistent > net: tlan: use pci_zalloc_consistent > enic: use pci_zalloc_consistent > > drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 2 +- > drivers/net/ethernet/atheros/atlx/atl1.c | 8 +++---- > drivers/net/ethernet/atheros/atlx/atl2.c | 5 ++-- > drivers/net/ethernet/cisco/enic/vnic_dev.c | 3 +-- > drivers/net/ethernet/neterion/s2io.c | 10 ++++---- > .../net/ethernet/qlogic/netxen/netxen_nic_ctx.c | 26 ++++++++------------ > drivers/net/ethernet/ti/tlan.c | 7 +++--- > drivers/net/hippi/rrunner.c | 28 +++++++++------------- > 8 files changed, 35 insertions(+), 54 deletions(-) > > -- > 2.7.0 > >
On Tue, Jun 5, 2018 at 3:49 PM, Christoph Hellwig <hch@lst.de> wrote: > On Tue, Jun 05, 2018 at 03:39:16PM +0300, Andy Shevchenko wrote: >> On Tue, Jun 5, 2018 at 3:28 PM, YueHaibing <yuehaibing@huawei.com> wrote: >> > >> >> Hmm... Is PCI case anyhow special or it's a simple wrapper on top of >> dma.*alloc() ? > > All drivers should move from pci_dma* to dma_* eventually. Converting > from one flavor of deprecated to another is completely pointless. Exactly my impression. Thanks, Christoph for clarification. YueHaibing, care to follow what Christoph said and change your series accordingly?
On Tue, Jun 05, 2018 at 03:39:16PM +0300, Andy Shevchenko wrote: > On Tue, Jun 5, 2018 at 3:28 PM, YueHaibing <yuehaibing@huawei.com> wrote: > > > > Hmm... Is PCI case anyhow special or it's a simple wrapper on top of > dma.*alloc() ? All drivers should move from pci_dma* to dma_* eventually. Converting from one flavor of deprecated to another is completely pointless.
From: Christoph Hellwig <hch@lst.de> Date: Tue, 5 Jun 2018 14:49:29 +0200 > On Tue, Jun 05, 2018 at 03:39:16PM +0300, Andy Shevchenko wrote: >> On Tue, Jun 5, 2018 at 3:28 PM, YueHaibing <yuehaibing@huawei.com> wrote: >> > >> >> Hmm... Is PCI case anyhow special or it's a simple wrapper on top of >> dma.*alloc() ? > > All drivers should move from pci_dma* to dma_* eventually. Converting > from one flavor of deprecated to another is completely pointless. Agreed.
On 2018/6/5 20:46, Andy Shevchenko wrote: > On Tue, Jun 5, 2018 at 3:49 PM, Christoph Hellwig <hch@lst.de> wrote: >> On Tue, Jun 05, 2018 at 03:39:16PM +0300, Andy Shevchenko wrote: >>> On Tue, Jun 5, 2018 at 3:28 PM, YueHaibing <yuehaibing@huawei.com> wrote: >>>> >>> >>> Hmm... Is PCI case anyhow special or it's a simple wrapper on top of >>> dma.*alloc() ? >> >> All drivers should move from pci_dma* to dma_* eventually. Converting >> from one flavor of deprecated to another is completely pointless. > > Exactly my impression. Thanks, Christoph for clarification. > > YueHaibing, care to follow what Christoph said and change your series > accordingly? ok, will send v2 >