| Message ID | 20180530175950.9488-1-saeedm@mellanox.com |
|---|---|
| Headers | show |
| Series | Mellanox, mlx5 new device events | expand |
On Wed, 2018-05-30 at 10:59 -0700, Saeed Mahameed wrote: > Hi, > > The following series is for mlx5-next tree [1], it adds the support of two > new device events, from Ilan Tayari: > > 1. High temperature warnings. > 2. FPGA QP error event. > > In case of no objection this series will be applied to mlx5-next tree > and will be sent later as a pull request to both rdma and net trees. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next > > v1->v2: > - improve commit message of the FPGA QP error event patch. > > Thanks, > Saeed. > > Ilan Tayari (2): > net/mlx5: Add temperature warning event to log > net/mlx5: Add FPGA QP error event > > drivers/net/ethernet/mellanox/mlx5/core/eq.c | 28 +++++++++++++++++++- > include/linux/mlx5/device.h | 8 ++++++ > include/linux/mlx5/mlx5_ifc.h | 3 ++- > include/linux/mlx5/mlx5_ifc_fpga.h | 16 +++++++++++ > 4 files changed, 53 insertions(+), 2 deletions(-) > For the RDMA community, series ack: Acked-by: Doug Ledford <dledford@redhat.com>
From: Saeed Mahameed <saeedm@mellanox.com> Date: Wed, 30 May 2018 10:59:48 -0700 > The following series is for mlx5-next tree [1], it adds the support of two > new device events, from Ilan Tayari: > > 1. High temperature warnings. > 2. FPGA QP error event. > > In case of no objection this series will be applied to mlx5-next tree > and will be sent later as a pull request to both rdma and net trees. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next > > v1->v2: > - improve commit message of the FPGA QP error event patch. Series applied, thanks.
On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote: > From: Saeed Mahameed <saeedm@mellanox.com> > Date: Wed, 30 May 2018 10:59:48 -0700 > > > The following series is for mlx5-next tree [1], it adds the support of two > > new device events, from Ilan Tayari: > > > > 1. High temperature warnings. > > 2. FPGA QP error event. > > > > In case of no objection this series will be applied to mlx5-next tree > > and will be sent later as a pull request to both rdma and net trees. > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next > > > > v1->v2: > > - improve commit message of the FPGA QP error event patch. > > Series applied, thanks. Hi Dave, Although in this case it doesn't really matter and we can work around it, this was supposed to be a case of the new methodology that Saeed and Jason had worked out with you. Specifically, when Saeed says in the cover letter: > In case of no objection this series will be applied to mlx5-next tree> > and will be sent later as a pull request to both rdma and net trees. then it is intended for you to ack the original patch series, not apply it, and when acks from both the net and rdma side have been received, then we will get a pull request of just that series.
From: Doug Ledford <dledford@redhat.com> Date: Fri, 01 Jun 2018 11:08:24 -0400 > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote: >> From: Saeed Mahameed <saeedm@mellanox.com> >> Date: Wed, 30 May 2018 10:59:48 -0700 >> >> > The following series is for mlx5-next tree [1], it adds the support of two >> > new device events, from Ilan Tayari: >> > >> > 1. High temperature warnings. >> > 2. FPGA QP error event. >> > >> > In case of no objection this series will be applied to mlx5-next tree >> > and will be sent later as a pull request to both rdma and net trees. >> > >> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next >> > >> > v1->v2: >> > - improve commit message of the FPGA QP error event patch. >> >> Series applied, thanks. > > Hi Dave, > > Although in this case it doesn't really matter and we can work around > it, this was supposed to be a case of the new methodology that Saeed and > Jason had worked out with you. Specifically, when Saeed says in the > cover letter: > >> In case of no objection this series will be applied to mlx5-next tree> >> and will be sent later as a pull request to both rdma and net trees. > > then it is intended for you to ack the original patch series, not apply > it, and when acks from both the net and rdma side have been received, > then we will get a pull request of just that series. Sorry, I saw your ACK and misinterpreted the situation. I'll be more careful next time.
On Fri, Jun 01, 2018 at 11:45:58AM -0400, David Miller wrote: > From: Doug Ledford <dledford@redhat.com> > Date: Fri, 01 Jun 2018 11:08:24 -0400 > > > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote: > >> From: Saeed Mahameed <saeedm@mellanox.com> > >> Date: Wed, 30 May 2018 10:59:48 -0700 > >> > >> > The following series is for mlx5-next tree [1], it adds the support of two > >> > new device events, from Ilan Tayari: > >> > > >> > 1. High temperature warnings. > >> > 2. FPGA QP error event. > >> > > >> > In case of no objection this series will be applied to mlx5-next tree > >> > and will be sent later as a pull request to both rdma and net trees. > >> > > >> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next > >> > > >> > v1->v2: > >> > - improve commit message of the FPGA QP error event patch. > >> > >> Series applied, thanks. > > > > Hi Dave, > > > > Although in this case it doesn't really matter and we can work around > > it, this was supposed to be a case of the new methodology that Saeed and > > Jason had worked out with you. Specifically, when Saeed says in the > > cover letter: > > > >> In case of no objection this series will be applied to mlx5-next tree> > >> and will be sent later as a pull request to both rdma and net trees. > > > > then it is intended for you to ack the original patch series, not apply > > it, and when acks from both the net and rdma side have been received, > > then we will get a pull request of just that series. > > Sorry, I saw your ACK and misinterpreted the situation. > > I'll be more careful next time. Doug, Dave I would like to clarify this point, we intend to send pull request to only one maintainer, who actually needs the accepted patches. Let's take the RDMA flow counters series as an example: https://www.spinics.net/lists/linux-rdma/msg65620.html This series includes 12 patches for RDMA and 2 shared code (mlx5-next). Those two patches, the RDMA side will receive as part of specific pull request and netdev will get them if some netdev feature down the road will need mlx5-next branch. Of course, it is harmless for both of you to pull, but it looks like extra work which is not needed for you. Thanks > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2018-06-01 at 19:21 +0300, Leon Romanovsky wrote: > On Fri, Jun 01, 2018 at 11:45:58AM -0400, David Miller wrote: > > From: Doug Ledford <dledford@redhat.com> > > Date: Fri, 01 Jun 2018 11:08:24 -0400 > > > > > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote: > > > > From: Saeed Mahameed <saeedm@mellanox.com> > > > > Date: Wed, 30 May 2018 10:59:48 -0700 > > > > > > > > > The following series is for mlx5-next tree [1], it adds the support of two > > > > > new device events, from Ilan Tayari: > > > > > > > > > > 1. High temperature warnings. > > > > > 2. FPGA QP error event. > > > > > > > > > > In case of no objection this series will be applied to mlx5-next tree > > > > > and will be sent later as a pull request to both rdma and net trees. > > > > > > > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next > > > > > > > > > > v1->v2: > > > > > - improve commit message of the FPGA QP error event patch. > > > > > > > > Series applied, thanks. > > > > > > Hi Dave, > > > > > > Although in this case it doesn't really matter and we can work around > > > it, this was supposed to be a case of the new methodology that Saeed and > > > Jason had worked out with you. Specifically, when Saeed says in the > > > cover letter: > > > > > > > In case of no objection this series will be applied to mlx5-next tree> > > > > and will be sent later as a pull request to both rdma and net trees. > > > > > > then it is intended for you to ack the original patch series, not apply > > > it, and when acks from both the net and rdma side have been received, > > > then we will get a pull request of just that series. > > > > Sorry, I saw your ACK and misinterpreted the situation. > > > > I'll be more careful next time. > > Doug, Dave > > I would like to clarify this point, we intend to send pull request to only > one maintainer, who actually needs the accepted patches. > > Let's take the RDMA flow counters series as an example: > https://www.spinics.net/lists/linux-rdma/msg65620.html > > This series includes 12 patches for RDMA and 2 shared code > (mlx5-next). Those two patches, the RDMA side will receive as part > of specific pull request and netdev will get them if some netdev > feature down the road will need mlx5-next branch. > > Of course, it is harmless for both of you to pull, but it looks like > extra work which is not needed for you. Ok, thanks for the clarification Leon.
On Fri, 2018-06-01 at 11:45 -0400, David Miller wrote: > From: Doug Ledford <dledford@redhat.com> > Date: Fri, 01 Jun 2018 11:08:24 -0400 > > > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote: > >> From: Saeed Mahameed <saeedm@mellanox.com> > >> Date: Wed, 30 May 2018 10:59:48 -0700 > >> > >> > The following series is for mlx5-next tree [1], it adds the support of two > >> > new device events, from Ilan Tayari: > >> > > >> > 1. High temperature warnings. > >> > 2. FPGA QP error event. > >> > > >> > In case of no objection this series will be applied to mlx5-next tree > >> > and will be sent later as a pull request to both rdma and net trees. > >> > > >> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next > >> > > >> > v1->v2: > >> > - improve commit message of the FPGA QP error event patch. > >> > >> Series applied, thanks. > > > > Hi Dave, > > > > Although in this case it doesn't really matter and we can work around > > it, this was supposed to be a case of the new methodology that Saeed and > > Jason had worked out with you. Specifically, when Saeed says in the > > cover letter: > > > >> In case of no objection this series will be applied to mlx5-next tree> > >> and will be sent later as a pull request to both rdma and net trees. > > > > then it is intended for you to ack the original patch series, not apply > > it, and when acks from both the net and rdma side have been received, > > then we will get a pull request of just that series. > > Sorry, I saw your ACK and misinterpreted the situation. > > I'll be more careful next time. Understandable, thanks ;-)
From: Leon Romanovsky <leonro@mellanox.com> Date: Fri, 1 Jun 2018 19:21:26 +0300 > Of course, it is harmless for both of you to pull, but it looks like > extra work which is not needed for you. Just put net-next or rdma-next in the subject line(s) and that will make it very clear what it expected to happen.
On Fri, Jun 01, 2018 at 01:08:18PM -0400, David Miller wrote: > From: Leon Romanovsky <leonro@mellanox.com> > Date: Fri, 1 Jun 2018 19:21:26 +0300 > > > Of course, it is harmless for both of you to pull, but it looks like > > extra work which is not needed for you. > > Just put net-next or rdma-next in the subject line(s) and that will > make it very clear what it expected to happen. It was our intention too. Thanks > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote: > From: Saeed Mahameed <saeedm@mellanox.com> > Date: Wed, 30 May 2018 10:59:48 -0700 > > > The following series is for mlx5-next tree [1], it adds the support > > of two > > new device events, from Ilan Tayari: > > > > 1. High temperature warnings. > > 2. FPGA QP error event. > > > > In case of no objection this series will be applied to mlx5-next > > tree > > and will be sent later as a pull request to both rdma and net > > trees. > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux. > > git/log/?h=mlx5-next > > > > v1->v2: > > - improve commit message of the FPGA QP error event patch. > > Series applied, thanks. Hey Dave, this series was meant to go to mlx5-next tree as stated in the cover letter and patches titles "[PATCH V2 mlx5-next 0/2]". It is ok you applied those patches to net-next this time, but for next time I would like to apply them myself to mlx5-next and send a clean pull request later to both rdma and net trees. Is there a way for me to mark them as delegated in patchwork ? I see that i have "update Properties" option in patchwork but i don't know how to use it or whether I am allowed to do anything with it. Thanks, Saeed.
On Fri, 2018-06-01 at 17:13 -0700, saeedm@mellanox.com wrote: > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote: > > From: Saeed Mahameed <saeedm@mellanox.com> > > Date: Wed, 30 May 2018 10:59:48 -0700 > > > > > The following series is for mlx5-next tree [1], it adds the > > > support > > > of two > > > new device events, from Ilan Tayari: > > > > > > 1. High temperature warnings. > > > 2. FPGA QP error event. > > > > > > In case of no objection this series will be applied to mlx5-next > > > tree > > > and will be sent later as a pull request to both rdma and net > > > trees. > > > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linu > > > x. > > > git/log/?h=mlx5-next > > > > > > v1->v2: > > > - improve commit message of the FPGA QP error event patch. > > > > Series applied, thanks. > > Hey Dave, this series was meant to go to mlx5-next tree as stated in > the cover letter and patches titles "[PATCH V2 mlx5-next 0/2]". > > It is ok you applied those patches to net-next this time, but for > next > time I would like to apply them myself to mlx5-next and send a clean > pull request later to both rdma and net trees. > Sorry please ignore, I just saw that this was sorted out .. :). Thanks A lot ! > Is there a way for me to mark them as delegated in patchwork ? > I see that i have "update Properties" option in patchwork but i don't > know how to use it or whether I am allowed to do anything with it. > It would be great if we can mark such patches in patchwork though.. > Thanks, > Saeed.
From: Saeed Mahameed <saeedm@mellanox.com> Date: Sat, 2 Jun 2018 00:17:37 +0000 > On Fri, 2018-06-01 at 17:13 -0700, saeedm@mellanox.com wrote: >> Hey Dave, this series was meant to go to mlx5-next tree as stated in >> the cover letter and patches titles "[PATCH V2 mlx5-next 0/2]". >> >> It is ok you applied those patches to net-next this time, but for >> next >> time I would like to apply them myself to mlx5-next and send a clean >> pull request later to both rdma and net trees. > > Sorry please ignore, I just saw that this was sorted out .. :). > Thanks A lot ! > >> Is there a way for me to mark them as delegated in patchwork ? >> I see that i have "update Properties" option in patchwork but i don't >> know how to use it or whether I am allowed to do anything with it. > > It would be great if we can mark such patches in patchwork though.. I really don't like it when others adjust patchwork state on me. Florian Fainelli did it for a brief time for some of his own patches and it caused a lot of confusion for me, so I asked him to stop. Let's just make sure that the Subject line says mlx5-next or whatever instead of net-next and I'll be mindful in such situations. Thanks.