From patchwork Thu Mar 22 17:53:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 889508 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="mSFGjZTc"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 406Z6w3b64z9s1r for ; Fri, 23 Mar 2018 04:54:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751755AbeCVRyN (ORCPT ); Thu, 22 Mar 2018 13:54:13 -0400 Received: from mail-he1eur01on0078.outbound.protection.outlook.com ([104.47.0.78]:16568 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751319AbeCVRyL (ORCPT ); Thu, 22 Mar 2018 13:54:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WYDImPbDmeshAr4e4YQNngs0LCesN6eYiJlH1uXGt/4=; b=mSFGjZTcdpZBFNuZ+nJBfToCNb58eQLAEMoDsl2IdUTZSveT1WQ+ROitIIy4hpriO5vsvRk7Xvpv8D7X4MYvOpV4ebhMnK93PD94cMK/2ixU4/f5VSkwbjJ2TNYJhAfVuf99wmVCG+7Dy+nhpSj5VjsnPX8YLmfK7Y4L/WnJkms= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Received: from splinter.mtl.com (193.47.165.251) by AM5PR0501MB2003.eurprd05.prod.outlook.com (2603:10a6:203:1a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.609.10; Thu, 22 Mar 2018 17:54:08 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, lucien.xin@gmail.com, mlxsw@mellanox.com, Ido Schimmel Subject: [PATCH net 0/3] mlxsw: Handle changes to MTU in GRE tunnels Date: Thu, 22 Mar 2018 19:53:32 +0200 Message-Id: <20180322175335.26232-1-idosch@mellanox.com> X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM0PR0102CA0045.eurprd01.prod.exchangelabs.com (2603:10a6:208::22) To AM5PR0501MB2003.eurprd05.prod.outlook.com (2603:10a6:203:1a::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b58764fa-2ca6-429d-d2ed-08d5901de95d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2003; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2003; 3:OSKiSfrnyCpIQE+BSTrNR6/OYL6S7ziw89+xiky5xItkUVSxjQhlguclb6sMsoj9lQb+nldgd1DbKkg0+Y4VBMfEmFy6vwLgaookGlY5Zt2WHRQmsaGeRvjPBAp72JwnMEvU3ZKW+Tb9fWqx2QNbksAD25Or4IZb2gTqJ5kj2kWywA/urXEVQ81dxJwqBBKSmORYZTRX+Fwblh5HcROQd6FkL250TFNqUevU0sRn9arf74RODOddDF7mu1x5+M7l; 25:BYovjiCdZojDOHDT0NAIYjW/4mzKf6yDbjcoZ8SC3FXpmUqTlO7jnJrALP+6omK+HpPtzK80adxnrUmJkTuTnjVumpkxFF/z4wwvT8sRCR2fg7rgXECqNrAiMQvqLO4BGb6mhF9h2QCmHkBD6/ca4KkFnBv8y0F7DyMl4nN/LTrWMLW2Eh2DVNmaTRtpHlISyJ9HcpACbbu4WFmie9L9lqjxjrFoHD+06xr12zRyGuh6yyO6NNL9Ab0Jno4X0UnmrS0H7QAeSxU15G7xAw40zA8xV0baNHfaXe7KzemUXlssl1RvuyZ90a8Aj2pey4upvlbkTPGbWSiHrk1fGepHhQ==; 31:lT6EaSdDyy6RJOc8tWI1Y1OFxjDeW2HvMVfT3KJKK5jv3ku3f9C8/phUfdwLAavUz0ul7ThknJZJ1RIkBdlZGGcHZMB9kTK5byDKMj77ULs5s75sNvx53wWAF6EHu6ZWjL/oErW3SVFR1JYz/Qns77vHqOlwjlXzX9JEo0WtBcv3VHcQIQSbaf35trASbl88EeEcLcxLx3H1dQpgsukTT4O7EmmuI7tj2ASJs5wdvec= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2003: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2003; 20:D+VsyDYSdV5V0M7/pjKVDReSdUa1ie9t00qTzC5rnrGObehZsj62LDDOIncW3c0RZsT4gjkbbVCd9VE1JupuKTiP0fZuIl14GFMUXrdivMnauOG4RDNejIDo3nP4F0sYnMMMSa+VjDlkdjogq+K+0BrJpU6G3DGKmsziSGlKfwgCWy4cgoeo3oONilX3F2nTP+B4UXCwzZriiS14Z/uql70hFRSCUcvzhqVEeLT8xhptWdA7qXFwpaQIG7t5HFBbDY4vvc2hf4zfH97kP5nkIE2+ijbC89NVbbKvAd/QwLhK3FCpw1OS7BsHFMVvUMc/QEfGVyimezXubrf+w50T40pBBIb/UTiqYdVj0cuxF0xmwednzn6Krn2zRfOaTpot7RRkmcQGUu8/t4O7sCIchrwCe+CQkXPJ6evTTL16bmcJz7wSSmJ9dflFUc8/xNzUgWZE8wGlCoHSAy1xBGAG9KHPiVKS2CbC3wv8O+tWemLt5lxKXciJK2fHqL8fdCHo; 4:ZDCOs70arr1ZdwroWOgHaBS7P3j851ZHH8ZOd6H62M3SNqmpWsHMUO0g+aFMlX3UiLYo08x+m9nBXD5bp9Pc+xwtk4Fxka17Ykddy0K7SnYurfCVViP/GWq+XThNPpk5HbDmeuunrKWnwJKpLwEMFwBYV3J/dXp1xoPlD8rOtv9RtjwdiZAsGS0jSi+O2eBbPvl4+yOUTDcq7oBfmobcSrw6iZaO0TK/4TchuMbL5TaYOjxvcA2QsbkF+ef7vtBW2re/6DyjjTu+YRd2XoazGQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:AM5PR0501MB2003; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2003; X-Forefront-PRVS: 0619D53754 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39380400002)(396003)(39860400002)(199004)(189003)(97736004)(6666003)(86362001)(26005)(2906002)(6916009)(47776003)(6486002)(66066001)(107886003)(53936002)(25786009)(106356001)(4326008)(51416003)(1076002)(3846002)(8676002)(7736002)(50226002)(6512007)(305945005)(6116002)(36756003)(105586002)(6506007)(386003)(39060400002)(53416004)(81156014)(478600001)(81166006)(50466002)(48376002)(5660300001)(8936002)(68736007)(52116002)(316002)(186003)(16526019)(2361001)(16586007)(2351001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2003; H:splinter.mtl.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2003; 23:5WkCfNeOo+1BA3wLQ12Xago4I1HhmsbZx2G8wUBSMFui/iUpFg2CdAXQ8RNbXi5JZvZtTJHlBIqy2qf07wPnBIbp3TBjOMdxqN6UAi/ui9vcPq04bQ7FXCcE9pcSZforgDtmbtyK1z8JQoMXGDLjAPlOIiyM7h2f6eARKPk7ioujqrn1HzaWYQ8IWOFad79fl+YX6msgMx4NR6kbm3LPFZI6P/3pRhXdSchxLVuXmW/6KYNUaM5x5YZWBsUMsunRdyC1PaUV0hnIoI1QgS7vRUsWEEyxYvLRy/ugfEwzaHQS94Bame7BV8Ub6uPpVFEpLE8Yl4iKt8heKmHxUCpAXwmFABnZIna4MOWSsnVbImB2Mw7io+7VOIlWX5NilWB6gF/IGXewH8qCecZvOifTxnUAfOkJ4DU1ZZ+aIMgeUFWHEqq97stsejWwsvQwtN9XetDJme4X5fB9vJ9J0s1JgPomCDicrwSAn/va6vscKK8Wqnoagm910Dowg9DIjU68wP46xphRmu10xExsQZ5DebJxIsACMiUBKfJAuvfKkeny8+Cj2hzUnA0GA5Osxvsl9JVKoC38xChpnJ8nw+mqGCDctwlPcB2Ozb+118PGtcZYQocE7oiPImgpuGxQQMMP7VAELDpyHs2icKCiKIPI/MDftFa8g0/KP+C+x8LDYtZ8rxfasQCUJyvqCvUNe/UX6lDb+7W7v7EeRUoPcsGvVETilUA2XvNvBjVwZsiTvvCHewS77ztQBxH993eXSK1qKFq2igDPhhxyi5dAMUWL0uCKaIG28/aocZy7UlsO1bzcgNjOHjM59L7JOlmuCFKVB6ZC8k1vAUPDFKNw4kiIzGAKe+iJk1pFptfq4iyjX28nSIxIptlVDGRHFUstytzYPFn5q6Ea6uu5pMONLen+rRtGicGXMKQ52s79ByU9QmrfLX3ZKhLBezBBKRJGHvUw/yvSm0Zo7tTt+mf2QrzBbCXc120Jr5PmEfSm11XzosEq18247+4Eg6M6i0GPnxoeBZmkZ5JUXVGwBparznFr9BqMMriTwqWO+/AwfRARhxSyzBIrGY8a6Oq3UN3SGS3rWDo99KGfGLreeZVUFgJWdmfvYifFJSSuEStWIgimjbLiKOQ0j6DJHQNqIIAECDgXHKPEcyQ3SjUNCQA1LbcAAGq5E0fh4gWYXi/NhLVedBI= X-Microsoft-Antispam-Message-Info: 0wN2ngyXRUqH8+MsmOD/Jwd9TCwvHvJQKuOy953JWKrjVcA6Lb/yyD4Z2J9gKQgGFHZ06oTO2djSHhBvx393jk9p8AKQnlBc/+cr0NyNsUwqFhKHBbg/NNyyjcYVdPDILn80yiLc8lLiaP6745SBJslgr0rqUEy7JBUt7OQK0SSHBZHiss+H6fanzSnVAZPP X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2003; 6:zYGbProUQE8vluMPQQyZyjiQKaFk7rDYvswDs9lY5vpXaumgLE8X4JHqJ46Cx5wXQ7lPg73SpdTv7Uu0sBOXpZ+rzu/XIjidP4F/Ohh7Hh8WMtgCH+igEEWm7Bewvr/a38R74URB3jRMHsf6Q4SS36Kk4R+aUFcvy5tbL6aAIVd/a76DLc0ji4LcyJmTwTI9nj9F5u+m42X4FpzREmqgqVbOOteUR0OtiM1O56VcCAyNUcfNCqpC3gRScXw96AAXm7o0cjCCqhaf+hb3geKxrJ5QFdNkSajs46zhNdAVknKr37bqrRiU/gTSOEbuFksfO8TVV4zj4h83BUxpQLDqjduGFIKkac71qbjBiZ0le9YgMOYsdP9edEF7x9d5EFlm/x9hUCZOsbeCR9p64b680hmxiR1pImRgPUbzy3fnfWKMJ1ILVNIT0mGa8Z5D4ZLALB6tAkzLuXk93yJtwylamA==; 5:VZnHwzs4AQyWFzfoFMc8Nb2K5PTmW8KIW3yx5Fiv901ZZmHHxQ6xJb7L+hbC3nDGxSsyTq4YnAK3j+XlUHZIlTM1AukaljW0YzjoLotfgqxKGRAzivZbTWwmXhZhHZJ/Uk2/EqXlvK/c8c5i5eiDGAdoJsRFieW30Wqz22fb/30=; 24:Wgtmy0/+nSbnVydzAo4E9hi+VUbq0SPUqoN193VnpyuHKIP2dFTFfemx1boDSutsHUdQlYpHzUK4BHbWh+QoEKP+LiutRrxjNGywj0GNro4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2003; 7:0ZFzafloke56JXOCD8wHF75wSfeBBaEC2ZwFvhHo9CDYCXcfR7ImUWLFuFk8k4W94djgdncIIqa2PqmSLu1klfuKRuS/opAmq6TxwsjWke2QCwiECntlVZv3qLrX8Hdfb3pYoDxSf+fhG9Xjz9eoaJVtxiRv+HIfWRT0ZfJO8/bC8fN7s0bnEYS2MDk3OMjM+ChO+PFOb+GvCNXN3bO3jPNvvVToOn9cMbTEI+x3VhzvOmxUDQNwo0/3bfI2e94O X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2018 17:54:08.1015 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b58764fa-2ca6-429d-d2ed-08d5901de95d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2003 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Petr says: When offloading GRE tunnels, the MTU setting is kept fixed after the initial offload even as the slow-path configuration changed. Worse: the offloaded MTU setting is actually just a transient value set at the time of NETDEV_REGISTER of the tunnel. As of commit ffc2b6ee4174 ("ip_gre: fix IFLA_MTU ignored on NEWLINK"), that transient value is zero, and unless there's e.g. a VRF migration that prompts re-offload, it stays at zero, and all GRE packets end up trapping. Thus, in patch #1, change the way the MTU is changed post-registration, so that the full event protocol is observed. That way the drivers get to see the change and have a chance to react. In the remaining two patches, implement support for MTU change in mlxsw driver. Petr Machata (3): ip_tunnel: Emit events for post-register MTU changes mlxsw: spectrum_router: Move mlxsw_sp_rif_ipip_lb_op() mlxsw: spectrum_router: Handle MTU change of GRE netdevs .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 78 ++++++++++++++-------- net/ipv4/ip_tunnel.c | 26 ++++++-- 2 files changed, 72 insertions(+), 32 deletions(-)