mbox series

[net-next,0/2] tcp_bbr: more GSO work

Message ID 20180228224047.123054-1-edumazet@google.com
Headers show
Series tcp_bbr: more GSO work | expand

Message

Eric Dumazet Feb. 28, 2018, 10:40 p.m. UTC 
Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots,
I found that BBR was performing poorly, because of TSO being limited to 16KB

This patch series makes sure BBR is not under estimating number
of packets that are needed to fill the pipe when a device has
suboptimal TSO limits.

Eric Dumazet (2):
  tcp_bbr: better deal with suboptimal GSO (II)
  tcp_bbr: remove bbr->tso_segs_goal

 include/net/tcp.h     |  6 ++----
 net/ipv4/tcp_bbr.c    | 33 ++++++++++++++++-----------------
 net/ipv4/tcp_output.c | 15 ++++++++-------
 3 files changed, 26 insertions(+), 28 deletions(-)

Comments

Soheil Hassas Yeganeh Feb. 28, 2018, 10:42 p.m. UTC | #1 
On Wed, Feb 28, 2018 at 5:40 PM Eric Dumazet <edumazet@google.com> wrote:

> Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots,
> I found that BBR was performing poorly, because of TSO being limited to
16KB

> This patch series makes sure BBR is not under estimating number
> of packets that are needed to fill the pipe when a device has
> suboptimal TSO limits.

> Eric Dumazet (2):
>    tcp_bbr: better deal with suboptimal GSO (II)
>    tcp_bbr: remove bbr->tso_segs_goal

Acked-by: Soheil Hassas Yeganeh <soheil@google.com>

Thank you, Eric!

>   include/net/tcp.h     |  6 ++----
>   net/ipv4/tcp_bbr.c    | 33 ++++++++++++++++-----------------
>   net/ipv4/tcp_output.c | 15 ++++++++-------
>   3 files changed, 26 insertions(+), 28 deletions(-)

> --
> 2.16.2.395.g2e18187dfd-goog
David Miller March 2, 2018, 2:44 a.m. UTC | #2 
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 28 Feb 2018 14:40:45 -0800

> Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots,
> I found that BBR was performing poorly, because of TSO being limited to 16KB
> 
> This patch series makes sure BBR is not under estimating number
> of packets that are needed to fill the pipe when a device has
> suboptimal TSO limits.

Series applied, thanks Eric.