mbox series

[net-next,0/2] nfp: ethtool flash updates

Message ID 20171213224502.25407-1-jakub.kicinski@netronome.com
Headers show
Series nfp: ethtool flash updates | expand

Message

Jakub Kicinski Dec. 13, 2017, 10:45 p.m. UTC 
Dirk says:

This series adds the ability to update the control FW with ethtool.

It should be noted that the locking scheme here is to release the RTNL
lock before the flashing operation and to take it again afterwards to
ensure consistent state from the core code point of view. In this time,
we take a reference to the device to prevent the device being freed
while its being flashed.

This provides protection for the device being flashed while at the same
time not holding up any networking related functions which would
otherwise be locked out due to RTNL being held.


Dirk van der Merwe (2):
  nfp: extend NSP infrastructure for configurable timeouts
  nfp: implement firmware flashing

 .../net/ethernet/netronome/nfp/nfp_net_ethtool.c   | 54 +++++++++++++++++
 .../net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c   | 68 +++++++++++++++++-----
 .../net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h   |  1 +
 3 files changed, 107 insertions(+), 16 deletions(-)

Comments

David Miller Dec. 15, 2017, 5:26 p.m. UTC | #1 
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 13 Dec 2017 14:45:00 -0800

> Dirk says:
> 
> This series adds the ability to update the control FW with ethtool.
> 
> It should be noted that the locking scheme here is to release the RTNL
> lock before the flashing operation and to take it again afterwards to
> ensure consistent state from the core code point of view. In this time,
> we take a reference to the device to prevent the device being freed
> while its being flashed.
> 
> This provides protection for the device being flashed while at the same
> time not holding up any networking related functions which would
> otherwise be locked out due to RTNL being held.

Series applied, thanks.