| Message ID | 1596220042-2778-1-git-send-email-pillair@codeaurora.org |
|---|---|
| Headers | show |
| Series | | expand |
On 7/31/20 11:27 AM, Rakesh Pillai wrote: > The history recording will be compiled only if > ATH10K_DEBUG is enabled, and also enabled via > the module parameter. Once the history recording > is enabled via module parameter, it can be enabled > or disabled runtime via debugfs. Why not use trace prints and retrieving them via the function tracer? This seems very ad-hoc. > > --- > Changes from v1: > - Add module param and debugfs to enable/disable history recording. > > Rakesh Pillai (3): > ath10k: Add history for tracking certain events > ath10k: Add module param to enable history > ath10k: Add debugfs support to enable event history > > drivers/net/wireless/ath/ath10k/ce.c | 1 + > drivers/net/wireless/ath/ath10k/core.c | 3 + > drivers/net/wireless/ath/ath10k/core.h | 82 ++++++++++++ > drivers/net/wireless/ath/ath10k/debug.c | 207 ++++++++++++++++++++++++++++++ > drivers/net/wireless/ath/ath10k/debug.h | 75 +++++++++++ > drivers/net/wireless/ath/ath10k/snoc.c | 15 ++- > drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 + > drivers/net/wireless/ath/ath10k/wmi.c | 10 ++ > 8 files changed, 393 insertions(+), 1 deletion(-) >
On Fri, 31 Jul 2020 23:57:19 +0530 Rakesh Pillai wrote: > The history recording will be compiled only if > ATH10K_DEBUG is enabled, and also enabled via > the module parameter. Once the history recording > is enabled via module parameter, it can be enabled > or disabled runtime via debugfs. Have you seen the trace_devlink_hwmsg() interface? Could it be used here?
> -----Original Message----- > From: Florian Fainelli <f.fainelli@gmail.com> > Sent: Saturday, August 1, 2020 12:17 AM > To: Rakesh Pillai <pillair@codeaurora.org>; ath10k@lists.infradead.org > Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; > kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org; > netdev@vger.kernel.org > Subject: Re: [PATCH v2 0/3] > > On 7/31/20 11:27 AM, Rakesh Pillai wrote: > > The history recording will be compiled only if > > ATH10K_DEBUG is enabled, and also enabled via > > the module parameter. Once the history recording > > is enabled via module parameter, it can be enabled > > or disabled runtime via debugfs. > > Why not use trace prints and retrieving them via the function tracer? > This seems very ad-hoc. Tracing needs to be enabled to capture the events. But these events can be turned on in some kind of a debug build and capture the history to help us debug in case there is a crash. It wont even allocate memory if not enabled via module parameter. > > > > > --- > > Changes from v1: > > - Add module param and debugfs to enable/disable history recording. > > > > Rakesh Pillai (3): > > ath10k: Add history for tracking certain events > > ath10k: Add module param to enable history > > ath10k: Add debugfs support to enable event history > > > > drivers/net/wireless/ath/ath10k/ce.c | 1 + > > drivers/net/wireless/ath/ath10k/core.c | 3 + > > drivers/net/wireless/ath/ath10k/core.h | 82 ++++++++++++ > > drivers/net/wireless/ath/ath10k/debug.c | 207 > ++++++++++++++++++++++++++++++ > > drivers/net/wireless/ath/ath10k/debug.h | 75 +++++++++++ > > drivers/net/wireless/ath/ath10k/snoc.c | 15 ++- > > drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 + > > drivers/net/wireless/ath/ath10k/wmi.c | 10 ++ > > 8 files changed, 393 insertions(+), 1 deletion(-) > > > > > -- > Florian
On 7/31/2020 10:10 PM, Rakesh Pillai wrote: > > >> -----Original Message----- >> From: Florian Fainelli <f.fainelli@gmail.com> >> Sent: Saturday, August 1, 2020 12:17 AM >> To: Rakesh Pillai <pillair@codeaurora.org>; ath10k@lists.infradead.org >> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; >> kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org; >> netdev@vger.kernel.org >> Subject: Re: [PATCH v2 0/3] >> >> On 7/31/20 11:27 AM, Rakesh Pillai wrote: >>> The history recording will be compiled only if >>> ATH10K_DEBUG is enabled, and also enabled via >>> the module parameter. Once the history recording >>> is enabled via module parameter, it can be enabled >>> or disabled runtime via debugfs. >> >> Why not use trace prints and retrieving them via the function tracer? >> This seems very ad-hoc. > > Tracing needs to be enabled to capture the events. > But these events can be turned on in some kind of a debug build and capture the history to help us debug in case there is a crash. > It wont even allocate memory if not enabled via module parameter. I would suggest researching what other drivers do and also considering the benefits, for someone doing system analysis of plugging into the kernel's general tracing mechanism to have all information in the same place and just do filtering on the record/report side.