| Message ID | 1590390569-4394-1-git-send-email-fugang.duan@nxp.com |
|---|---|
| Headers | show |
| Series | net: ethernet: fec: move GPR reigster offset and bit into DT | expand |
On Mon, May 25, 2020 at 03:09:25PM +0800, fugang.duan@nxp.com wrote: > From: Fugang Duan <fugang.duan@nxp.com> > > The commit da722186f654 (net: fec: set GPR bit on suspend by DT configuration) set the GPR reigster offset and bit in driver for wol feature. The cover letter gets committed as the merge commit message. So please wrap long longs. > It bring trouble to enable wol feature on imx6sx/imx6ul/imx7d > platforms that have multiple ethernet instances with different GPR > bit for stop mode control. So the patch set is to move GPR reigster register > offset and bit define into DT, and enable > imx6q/imx6dl/imx6sx/imx6ul/imx7d stop mode support. > > Currently, below NXP i.MX boards support wol: > - imx6q/imx6dl sabresd > - imx6sx sabreauto > - imx7d sdb > > imx6q/imx6dl sarebsd board dts file miss the property "fsl,magic-packet;", so patch#4 is to add the property for stop mode support. sabresd? Andrew
From: Andrew Lunn <andrew@lunn.ch> Sent: Monday, May 25, 2020 9:55 PM > On Mon, May 25, 2020 at 03:09:25PM +0800, fugang.duan@nxp.com wrote: > > From: Fugang Duan <fugang.duan@nxp.com> > > > > The commit da722186f654 (net: fec: set GPR bit on suspend by DT > configuration) set the GPR reigster offset and bit in driver for wol feature. > > The cover letter gets committed as the merge commit message. So please > wrap long longs. > > > It bring trouble to enable wol feature on imx6sx/imx6ul/imx7d > > platforms that have multiple ethernet instances with different GPR bit > > for stop mode control. So the patch set is to move GPR reigster > > register > Got it, will correct the typo in v3. > > offset and bit define into DT, and enable > > imx6q/imx6dl/imx6sx/imx6ul/imx7d stop mode support. > > > > > > Currently, below NXP i.MX boards support wol: > > - imx6q/imx6dl sabresd > > - imx6sx sabreauto > > - imx7d sdb > > > > imx6q/imx6dl sarebsd board dts file miss the property "fsl,magic-packet;", > so patch#4 is to add the property for stop mode support. > > sabresd? > > Andrew Thanks, I will correct the typo in v3.
From: Fugang Duan <fugang.duan@nxp.com> The commit da722186f654 (net: fec: set GPR bit on suspend by DT configuration) set the GPR reigster offset and bit in driver for wol feature. It bring trouble to enable wol feature on imx6sx/imx6ul/imx7d platforms that have multiple ethernet instances with different GPR bit for stop mode control. So the patch set is to move GPR reigster offset and bit define into DT, and enable imx6q/imx6dl/imx6sx/imx6ul/imx7d stop mode support. Currently, below NXP i.MX boards support wol: - imx6q/imx6dl sabresd - imx6sx sabreauto - imx7d sdb imx6q/imx6dl sarebsd board dts file miss the property "fsl,magic-packet;", so patch#4 is to add the property for stop mode support. v1 -> v2: - driver: switch back to store the quirks bitmask in driver_data - dt-bindings: rename 'gpr' property string to 'fsl,stop-mode' - imx6/7 dtsi: add imx6sx/imx6ul/imx7d ethernet stop mode property Thanks Martin and Andrew for the review. Fugang Duan (4): net: ethernet: fec: move GPR register offset and bit into DT dt-bindings: fec: update the gpr property ARM: dts: imx: add ethernet stop mode property ARM: dts: imx6qdl-sabresd: enable fec wake-on-lan Documentation/devicetree/bindings/net/fsl-fec.txt | 7 +- arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 + arch/arm/boot/dts/imx6qdl.dtsi | 2 +- arch/arm/boot/dts/imx6sx.dtsi | 2 + arch/arm/boot/dts/imx6ul.dtsi | 2 + arch/arm/boot/dts/imx7d.dtsi | 1 + arch/arm/boot/dts/imx7s.dtsi | 1 + drivers/net/ethernet/freescale/fec_main.c | 103 +++++++--------------- 8 files changed, 47 insertions(+), 72 deletions(-)