| Message ID | 1587619280-46386-1-git-send-email-roopa@cumulusnetworks.com |
|---|---|
| Headers | show |
| Series | nexthop: sysctl to skip route notifications on nexthop changes | expand |
On 4/23/20 8:48 AM, Roopa Prabhu wrote: > > > On Wed, Apr 22, 2020, 10:21 PM Roopa Prabhu <roopa@cumulusnetworks.com > <mailto:roopa@cumulusnetworks.com>> wrote: > > From: Roopa Prabhu <roopa@cumulusnetworks.com > <mailto:roopa@cumulusnetworks.com>> > > Route notifications on nexthop changes exists for backward > compatibility. In systems which have moved to the new > nexthop API, these route update notifications cancel > the performance benefits provided by the new nexthop API. > This patch adds a sysctl to disable these route notifications > > We have discussed this before. Maybe its time ? > > Roopa Prabhu (2): > ipv4: add sysctl to skip route notify on nexthop changes > ipv6: add sysctl to skip route notify on nexthop changes > > > > Will update the series with some self test results with sysctl on later > today. Expect v2 > and I have some changes for you. :-) There's a bit more to a "all of the processes know about nexthops; give me best performance" switch. I will send you a starter patch - the one I used for the LPC 2019 talk.
On Thu, Apr 23, 2020 at 8:10 AM David Ahern <dsahern@gmail.com> wrote: > > On 4/23/20 8:48 AM, Roopa Prabhu wrote: > > > > > > On Wed, Apr 22, 2020, 10:21 PM Roopa Prabhu <roopa@cumulusnetworks.com > > <mailto:roopa@cumulusnetworks.com>> wrote: > > > > From: Roopa Prabhu <roopa@cumulusnetworks.com > > <mailto:roopa@cumulusnetworks.com>> > > > > Route notifications on nexthop changes exists for backward > > compatibility. In systems which have moved to the new > > nexthop API, these route update notifications cancel > > the performance benefits provided by the new nexthop API. > > This patch adds a sysctl to disable these route notifications > > > > We have discussed this before. Maybe its time ? > > > > Roopa Prabhu (2): > > ipv4: add sysctl to skip route notify on nexthop changes > > ipv6: add sysctl to skip route notify on nexthop changes > > > > > > > > Will update the series with some self test results with sysctl on later > > today. Expect v2 > > > > and I have some changes for you. :-) > > There's a bit more to a "all of the processes know about nexthops; give > me best performance" switch. I will send you a starter patch - the one I > used for the LPC 2019 talk. okay, thanks. :) .
From: Roopa Prabhu <roopa@cumulusnetworks.com> Route notifications on nexthop changes exists for backward compatibility. In systems which have moved to the new nexthop API, these route update notifications cancel the performance benefits provided by the new nexthop API. This patch adds a sysctl to disable these route notifications We have discussed this before. Maybe its time ? Roopa Prabhu (2): ipv4: add sysctl to skip route notify on nexthop changes ipv6: add sysctl to skip route notify on nexthop changes include/net/netns/ipv4.h | 2 ++ include/net/netns/ipv6.h | 1 + net/ipv4/af_inet.c | 1 + net/ipv4/nexthop.c | 3 ++- net/ipv4/sysctl_net_ipv4.c | 7 +++++++ net/ipv6/route.c | 14 ++++++++++++++ 6 files changed, 27 insertions(+), 1 deletion(-)