mbox series

[net-next,00/12] net: hns3: add some bugfixes and optimizations

Message ID 1571210231-29154-1-git-send-email-tanhuazhong@huawei.com
Headers show
Series net: hns3: add some bugfixes and optimizations | expand

Message

tanhuazhong Oct. 16, 2019, 7:16 a.m. UTC 
This patch-set includes some bugfixes and code optimizations
for the HNS3 ethernet controller driver.

[patch 01/12] removes unused and unnecessary structures.

[patch 02/12] fixes a TX queue not restarted problem.

[patch 03/12] fixes a use-after-free issue.

[patch 04/12] fixes a mis-counting IRQ number issue.

[patch 05/12] fixes VF VLAN table entries inconsistent issue.

[patch 06/12] uses a ETH_ALEN u8 array to replace two mac_addr_*
field in struct hclge_mac_mgr_tbl_entry_cmd.

[patch 07/12] optimizes the barrier used in the IO path.

[patch 08/12] introduces macro ring_to_netdev() to get netdevive
from struct hns3_enet_ring variable.

[patch 09/12] adds a minor cleanup for hns3_handle_rx_bd().

[patch 10/12] fixes a VF ID issue for setting VF VLAN.

[patch 11/12] removes linear data allocating for fraglist SKB.

[patch 12/12] clears hardware error when resetting.

Guojia Liao (1):
  net: hns3: optimized MAC address in management table.

Jian Shen (3):
  net: hns3: fix VF VLAN table entries inconsistent issue
  net: hns3: fix VF id issue for setting VF VLAN
  net: hns3: log and clear hardware error after reset complete

Yonglong Liu (1):
  net: hns3: fix mis-counting IRQ vector numbers issue

Yunsheng Lin (7):
  net: hns3: remove struct hns3_nic_ring_data in hns3_enet module
  net: hns3: fix TX queue not restarted problem
  net: hns3: fix a use after freed problem in hns3_nic_maybe_stop_tx()
  net: hns3: minor optimization for barrier in IO path
  net: hns3: introduce ring_to_netdev() in enet module
  net: hns3: minor cleanup for hns3_handle_rx_bd()
  net: hns3: do not allocate linear data for fraglist skb

 drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h    |   1 +
 drivers/net/ethernet/hisilicon/hns3/hnae3.h        |   2 +
 drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c |  24 +-
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c    | 255 +++++++++------------
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.h    |  20 +-
 drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c |  33 ++-
 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h |   4 +-
 .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c    |  49 ++--
 .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h    |   1 +
 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c |   1 +
 .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c  |  11 +-
 .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c  |  32 ++-
 .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h  |   1 +
 13 files changed, 212 insertions(+), 222 deletions(-)

Comments

Jakub Kicinski Oct. 16, 2019, 5:19 p.m. UTC | #1 
On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
> This patch-set includes some bugfixes and code optimizations
> for the HNS3 ethernet controller driver.

The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4
should be a separate series targeting the net tree :(
David Miller Oct. 16, 2019, 5:50 p.m. UTC | #2 
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 16 Oct 2019 10:19:43 -0700

> On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
>> This patch-set includes some bugfixes and code optimizations
>> for the HNS3 ethernet controller driver.
> 
> The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4
> should be a separate series targeting the net tree :(

Agreed, there are legitimate bug fixes.

I have to say that I see this happening a lot, hns3 bug fixes targetting
net-next in a larger series of cleanups and other kinds of changes.

Please handle this delegation properly.  Send bug fixes as a series targetting
'net', and send everything else targetting 'net-next'.
tanhuazhong Oct. 17, 2019, 12:55 a.m. UTC | #3 
On 2019/10/17 1:19, Jakub Kicinski wrote:
> On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
>> This patch-set includes some bugfixes and code optimizations
>> for the HNS3 ethernet controller driver.
> 
> The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4
> should be a separate series targeting the net tree :(
> 

ok, I will pick out the bugfix and upstream to net tree firstly.
Thanks.

>
tanhuazhong Oct. 17, 2019, 12:56 a.m. UTC | #4 
On 2019/10/17 1:50, David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Wed, 16 Oct 2019 10:19:43 -0700
> 
>> On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
>>> This patch-set includes some bugfixes and code optimizations
>>> for the HNS3 ethernet controller driver.
>>
>> The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4
>> should be a separate series targeting the net tree :(
> 
> Agreed, there are legitimate bug fixes.
> 
> I have to say that I see this happening a lot, hns3 bug fixes targetting
> net-next in a larger series of cleanups and other kinds of changes.
> 
> Please handle this delegation properly.  Send bug fixes as a series targetting
> 'net', and send everything else targetting 'net-next'.
> 

ok, thanks.

> .
>
tanhuazhong Oct. 17, 2019, 3:27 a.m. UTC | #5 
On 2019/10/17 1:50, David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Wed, 16 Oct 2019 10:19:43 -0700
> 
>> On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
>>> This patch-set includes some bugfixes and code optimizations
>>> for the HNS3 ethernet controller driver.
>>
>> The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4
>> should be a separate series targeting the net tree :(
> 
> Agreed, there are legitimate bug fixes.
> 
> I have to say that I see this happening a lot, hns3 bug fixes targetting
> net-next in a larger series of cleanups and other kinds of changes.
> 
> Please handle this delegation properly.  Send bug fixes as a series targetting
> 'net', and send everything else targetting 'net-next'.
> 

Hi, David & Jakub.

BTW, patch01 is a cleanup which is needed by patch02,
if patch01 targetting 'net-next', patch02 targetting 'net',
there will be a gap again. How should I deal with this case?

MBR.
Huazhong.

> .
>
Jakub Kicinski Oct. 17, 2019, 3:47 p.m. UTC | #6 
On Thu, 17 Oct 2019 11:27:09 +0800, tanhuazhong wrote:
> On 2019/10/17 1:50, David Miller wrote:
> > From: Jakub Kicinski <jakub.kicinski@netronome.com>
> > Date: Wed, 16 Oct 2019 10:19:43 -0700
> >   
> >> On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:  
> >>> This patch-set includes some bugfixes and code optimizations
> >>> for the HNS3 ethernet controller driver.  
> >>
> >> The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4
> >> should be a separate series targeting the net tree :(  
> > 
> > Agreed, there are legitimate bug fixes.
> > 
> > I have to say that I see this happening a lot, hns3 bug fixes targetting
> > net-next in a larger series of cleanups and other kinds of changes.
> > 
> > Please handle this delegation properly.  Send bug fixes as a series targetting
> > 'net', and send everything else targetting 'net-next'.
> >   
> 
> Hi, David & Jakub.
> 
> BTW, patch01 is a cleanup which is needed by patch02,
> if patch01 targetting 'net-next', patch02 targetting 'net',
> there will be a gap again. How should I deal with this case?

You'll need to reorder the cleanup so that the fixes apply to the
unmodified net tree.

Then preferably wait for the net tree to be merged back to net-next
before posting the cleanup that'd conflict.  If the conflict is not 
too hard to resolve you can just post the net-next patches and give
some instructions on how to resolve the merge conflict under the ---
lines in the commit message.
tanhuazhong Oct. 18, 2019, 12:57 a.m. UTC | #7 
On 2019/10/17 23:47, Jakub Kicinski wrote:
> On Thu, 17 Oct 2019 11:27:09 +0800, tanhuazhong wrote:
>> On 2019/10/17 1:50, David Miller wrote:
>>> From: Jakub Kicinski <jakub.kicinski@netronome.com>
>>> Date: Wed, 16 Oct 2019 10:19:43 -0700
>>>    
>>>> On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote:
>>>>> This patch-set includes some bugfixes and code optimizations
>>>>> for the HNS3 ethernet controller driver.
>>>>
>>>> The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4
>>>> should be a separate series targeting the net tree :(
>>>
>>> Agreed, there are legitimate bug fixes.
>>>
>>> I have to say that I see this happening a lot, hns3 bug fixes targetting
>>> net-next in a larger series of cleanups and other kinds of changes.
>>>
>>> Please handle this delegation properly.  Send bug fixes as a series targetting
>>> 'net', and send everything else targetting 'net-next'.
>>>    
>>
>> Hi, David & Jakub.
>>
>> BTW, patch01 is a cleanup which is needed by patch02,
>> if patch01 targetting 'net-next', patch02 targetting 'net',
>> there will be a gap again. How should I deal with this case?
> 
> You'll need to reorder the cleanup so that the fixes apply to the
> unmodified net tree.
> 
> Then preferably wait for the net tree to be merged back to net-next
> before posting the cleanup that'd conflict.  If the conflict is not
> too hard to resolve you can just post the net-next patches and give
> some instructions on how to resolve the merge conflict under the ---
> lines in the commit message.
> 

ok, thanks.

> .
>