| Message ID | 1544035956-12375-1-git-send-email-jiong.wang@netronome.com |
|---|---|
| Headers | show |
| Series | bpf: support BPF_ALU | BPF_ARSH | expand |
On Wed, Dec 05, 2018 at 01:52:29PM -0500, Jiong Wang wrote: > BPF_ALU | BPF_ARSH | BPF_* were rejected by commit: 7891a87efc71 > ("bpf: arsh is not supported in 32 bit alu thus reject it"). As explained > in the commit message, this is due to there is no complete support for them > on interpreter and various JIT compilation back-ends. > > This patch set is a follow-up which completes the missing bits. This also > pave the way for running bpf program compiled with ALU32 instruction > enabled by specifing -mattr=+alu32 to LLVM for which case there is likely > to have more BPF_ALU | BPF_ARSH insns that will trigger the rejection code. > > test_verifier.c is updated accordingly. > > I have tested this patch set on x86-64 and NFP, I need help of review and > test on the arch changes (mips/ppc/s390). > > Note, there might be merge confict on mips change which is better to be > applied on top of: > > commit: 20b880a05f06 ("mips: bpf: fix encoding bug for mm_srlv32_op"), > > which is on mips-fixes branch at the moment. > > Thanks. > > v1->v2: > - Fix ppc implementation bug. Should zero high bits explicitly. I've applied this set and earlier commit "mips: bpf: fix encoding bug for mm_srlv32_op" to bpf-next. Thanks
BPF_ALU | BPF_ARSH | BPF_* were rejected by commit: 7891a87efc71 ("bpf: arsh is not supported in 32 bit alu thus reject it"). As explained in the commit message, this is due to there is no complete support for them on interpreter and various JIT compilation back-ends. This patch set is a follow-up which completes the missing bits. This also pave the way for running bpf program compiled with ALU32 instruction enabled by specifing -mattr=+alu32 to LLVM for which case there is likely to have more BPF_ALU | BPF_ARSH insns that will trigger the rejection code. test_verifier.c is updated accordingly. I have tested this patch set on x86-64 and NFP, I need help of review and test on the arch changes (mips/ppc/s390). Note, there might be merge confict on mips change which is better to be applied on top of: commit: 20b880a05f06 ("mips: bpf: fix encoding bug for mm_srlv32_op"), which is on mips-fixes branch at the moment. Thanks. v1->v2: - Fix ppc implementation bug. Should zero high bits explicitly. Cc: Paul Burton <paul.burton@mips.com> Cc: Naveen N. Rao <naveen.n.rao@linux.ibm.com> Cc: Sandipan Das <sandipan@linux.ibm.com> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Jiong Wang (7): mips: bpf: implement jitting of BPF_ALU | BPF_ARSH | BPF_X ppc: bpf: implement jitting of BPF_ALU | BPF_ARSH | BPF_* s390: bpf: implement jitting of BPF_ALU | BPF_ARSH | BPF_* nfp: bpf: implement jitting of BPF_ALU | BPF_ARSH | BPF_* bpf: interpreter support BPF_ALU | BPF_ARSH bpf: verifier remove the rejection on BPF_ALU | BPF_ARSH selftests: bpf: update testcases for BPF_ALU | BPF_ARSH arch/mips/include/asm/uasm.h | 1 + arch/mips/include/uapi/asm/inst.h | 1 + arch/mips/mm/uasm-micromips.c | 1 + arch/mips/mm/uasm-mips.c | 1 + arch/mips/mm/uasm.c | 9 ++--- arch/mips/net/ebpf_jit.c | 4 +++ arch/powerpc/include/asm/ppc-opcode.h | 2 ++ arch/powerpc/net/bpf_jit.h | 4 +++ arch/powerpc/net/bpf_jit_comp64.c | 6 ++++ arch/s390/net/bpf_jit_comp.c | 12 +++++++ drivers/net/ethernet/netronome/nfp/bpf/jit.c | 45 ++++++++++++++++++++++++ kernel/bpf/core.c | 52 ++++++++++++++++------------ kernel/bpf/verifier.c | 5 --- tools/testing/selftests/bpf/test_verifier.c | 29 +++++++++++++--- 14 files changed, 137 insertions(+), 35 deletions(-)