Message ID | 153918035266.8915.12458090320382567494.stgit@kernel |
---|---|
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=polito.it Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42VbVh2F0jz9s7W for <patchwork-incoming-netdev@ozlabs.org>; Thu, 11 Oct 2018 01:06:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbeJJV2h (ORCPT <rfc822;patchwork-incoming-netdev@ozlabs.org>); Wed, 10 Oct 2018 17:28:37 -0400 Received: from fm1nodo5.polito.it ([130.192.180.18]:51089 "EHLO fm1nodo5.polito.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbeJJV2h (ORCPT <rfc822;netdev@vger.kernel.org>); Wed, 10 Oct 2018 17:28:37 -0400 Received: from polito.it (frontmail2.polito.it [130.192.180.42]) by fm1nodo5.polito.it with ESMTP id w9AE5rth010170-w9AE5rtj010170 (version=TLSv1.0 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=CAFAIL); Wed, 10 Oct 2018 16:05:53 +0200 X-ExtScanner: Niversoft's FindAttachments (free) Received: from [130.192.225.241] (account d040768@polito.it HELO [127.0.1.1]) by polito.it (CommuniGate Pro SMTP 6.2.5) with ESMTPSA id 80410161; Wed, 10 Oct 2018 16:05:53 +0200 Subject: [PATCH bpf-next v2 0/7] Implement queue/stack maps From: Mauricio Vasquez B <mauricio.vasquez@polito.it> To: Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org Cc: Song Liu <liu.song.a23@gmail.com> Date: Wed, 10 Oct 2018 16:05:52 +0200 Message-ID: <153918035266.8915.12458090320382567494.stgit@kernel> User-Agent: StGit/unknown-version MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
Implement queue/stack maps
|
expand
|
In some applications this is needed have a pool of free elements, for example the list of free L4 ports in a SNAT. None of the current maps allow to do it as it is not possible to get any element without having they key it is associated to, even if it were possible, the lack of locking mecanishms in eBPF would do it almost impossible to be implemented without data races. This patchset implements two new kind of eBPF maps: queue and stack. Those maps provide to eBPF programs the peek, push and pop operations, and for userspace applications a new bpf_map_lookup_and_delete_elem() is added. Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it> v1 -> v2: - Put ARG_PTR_TO_UNINIT_MAP_VALUE logic into a separated patch - Fix missing __this_cpu_dec & preempt_enable calls in kernel/bpf/syscall.c RFC v4 -> v1: - Remove roundup to power of 2 in memory allocation - Remove count and use a free slot to check if queue/stack is empty - Use if + assigment for wrapping indexes - Fix some minor style issues - Squash two patches together RFC v3 -> RFC v4: - Revert renaming of kernel/bpf/stackmap.c - Remove restriction on value size - Remove len arguments from peek/pop helpers - Add new ARG_PTR_TO_UNINIT_MAP_VALUE RFC v2 -> RFC v3: - Return elements by value instead that by reference - Implement queue/stack base on array and head + tail indexes - Rename stack trace related files to avoid confusion and conflicts RFC v1 -> RFC v2: - Create two separate maps instead of single one + flags - Implement bpf_map_lookup_and_delete syscall - Support peek operation - Define replacement policy through flags in the update() method - Add eBPF side tests --- Mauricio Vasquez B (7): bpf: rename stack trace map operations bpf/syscall: allow key to be null in map functions bpf: add MAP_LOOKUP_AND_DELETE_ELEM syscall bpf/verifier: add ARG_PTR_TO_UNINIT_MAP_VALUE bpf: add queue and stack maps Sync uapi/bpf.h to tools/include selftests/bpf: add test cases for queue and stack maps include/linux/bpf.h | 8 + include/linux/bpf_types.h | 4 include/uapi/linux/bpf.h | 30 ++ kernel/bpf/Makefile | 2 kernel/bpf/core.c | 3 kernel/bpf/helpers.c | 43 +++ kernel/bpf/queue_stack_maps.c | 288 ++++++++++++++++++++ kernel/bpf/stackmap.c | 2 kernel/bpf/syscall.c | 110 +++++++- kernel/bpf/verifier.c | 28 ++ net/core/filter.c | 6 tools/include/uapi/linux/bpf.h | 30 ++ tools/lib/bpf/bpf.c | 12 + tools/lib/bpf/bpf.h | 1 tools/testing/selftests/bpf/Makefile | 5 tools/testing/selftests/bpf/bpf_helpers.h | 7 tools/testing/selftests/bpf/test_maps.c | 122 ++++++++ tools/testing/selftests/bpf/test_progs.c | 99 +++++++ tools/testing/selftests/bpf/test_queue_map.c | 4 tools/testing/selftests/bpf/test_queue_stack_map.h | 59 ++++ tools/testing/selftests/bpf/test_stack_map.c | 4 21 files changed, 853 insertions(+), 14 deletions(-) create mode 100644 kernel/bpf/queue_stack_maps.c create mode 100644 tools/testing/selftests/bpf/test_queue_map.c create mode 100644 tools/testing/selftests/bpf/test_queue_stack_map.h create mode 100644 tools/testing/selftests/bpf/test_stack_map.c --