From patchwork Fri Jun 8 17:12:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 926925 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nifty.com header.i=@nifty.com header.b="urCv+zs0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 412TcH0zbyz9s1B for ; Sat, 9 Jun 2018 03:17:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752676AbeFHRRQ (ORCPT ); Fri, 8 Jun 2018 13:17:16 -0400 Received: from condef-07.nifty.com ([202.248.20.72]:20081 "EHLO condef-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752609AbeFHRRP (ORCPT ); Fri, 8 Jun 2018 13:17:15 -0400 Received: from conuserg-10.nifty.com ([10.126.8.73])by condef-07.nifty.com with ESMTP id w58HD131004827 for ; Sat, 9 Jun 2018 02:13:01 +0900 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-10.nifty.com with ESMTP id w58HCbWC008555; Sat, 9 Jun 2018 02:12:37 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com w58HCbWC008555 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1528477958; bh=8V68o2aoXYaRMPIgzw9KVaMEFZ0hcDpbz1gesv8uClA=; h=From:To:Cc:Subject:Date:From; b=urCv+zs0MQDhAi/GnOifExwMv9iPDPkqxDtFlWdO0m0YeDyUGulgovrCCZpCI3Jjv 65EF5sx2xo3Yj9obJhdbpOZ8ShjEozHPxHvhHg1Evz86wRk1jE2KktZgOn7xZ6NZYo IBdOh5AgqULOA91csu/vQpfJflYAo+94yarp+DBzPl8xfIpunZ7omPA2mhw1B0Oncr MQPp3WmQSiOdpDpG02GzdFVTlTZGUNmw+RrI0eSUEDRT2bT1xvHHJ4j3uFx9bqm/O4 qqU8LdbKuOTT2X+2DqY6X8nOi9BCN+OTZ5jXTqCRYUc7qnqKfNE/jqCBXgoWTxU5zj mFdSKPpWD3dgA== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: netdev@vger.kernel.org, Alexei Starovoitov , "David S . Miller" Cc: Arnd Bergmann , Geert Uytterhoeven , linux-kernel@vger.kernel.org, Masahiro Yamada , YueHaibing Subject: [PATCH 0/3] net: bpfilter: clean-up build rules Date: Sat, 9 Jun 2018 02:12:07 +0900 Message-Id: <1528477930-7342-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I am unhappy with ugly hacks in this Makefile. (I could understand what is the hand-crafted .bpfilter_umh.o.cmd used for.) Moreover, CONFIG_OUTPUT_FORMAT is causing build errors because it is defined only for x86. As far as I understood, what is happening here is to embed the 'bpfilter_umh' as a blob. Instead, we can use '.incbin' to include it into a *.S file. Also, let's stop (ab)using host-program rules. Only build test is done. Masahiro Yamada (3): bpfilter: add bpfilter_umh to .gitignore bpfilter: include bpfilter_umh in assembly instead of using objcopy bpfilter: do not (ab)use host-program build rule net/bpfilter/.gitignore | 1 + net/bpfilter/Makefile | 30 ++++++++++++------------------ net/bpfilter/bpfilter_kern.c | 11 +++++------ net/bpfilter/{main.c => bpfilter_umh.c} | 0 net/bpfilter/bpfilter_umh_blob.S | 7 +++++++ 5 files changed, 25 insertions(+), 24 deletions(-) create mode 100644 net/bpfilter/.gitignore rename net/bpfilter/{main.c => bpfilter_umh.c} (100%) create mode 100644 net/bpfilter/bpfilter_umh_blob.S