From patchwork Sat Apr 21 16:41:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roopa Prabhu X-Patchwork-Id: 902489 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cumulusnetworks.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="O2unyNtA"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Sz5P3FXjz9s1P for ; Sun, 22 Apr 2018 02:41:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753130AbeDUQll (ORCPT ); Sat, 21 Apr 2018 12:41:41 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34885 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752902AbeDUQlk (ORCPT ); Sat, 21 Apr 2018 12:41:40 -0400 Received: by mail-pg0-f68.google.com with SMTP id j11so5472541pgf.2 for ; Sat, 21 Apr 2018 09:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id; bh=dx+jBirAGOyeHrFs9FgbCSbJ0YOVnptWPo4rqWGhAmE=; b=O2unyNtAdxJqsZb5z/S0idlL+lPwc5QjH7TmBTTEudovWN0qSxziqPRX/0Df5mDeDz Y6P6f/yO+YbeEIdD7/JgSJqaqRZ/mv+4edRebqXwMdq0rZsFfJ6tKowuxOtOXyGcb1Uk 89zIu5eoKlqphHyY3Ay9YH/AzRBr6UDklQowY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dx+jBirAGOyeHrFs9FgbCSbJ0YOVnptWPo4rqWGhAmE=; b=o7JfIH48qQv5D02DJgKqd8njJSIaGVtziuVK5FP9+fYOVxs6axPIOBIEaIpXuImHG8 sMn/Vwx80d4HQ35jREXlyd79G1zcZ8mEC3A2aisQ9dNKnCQla112PthM1kqeMoyfA1XK oQnE/j9mrEHpY3yIyvmwAhDBNUo7s0SKhs+SEBKfExKYj2TZOlSje/mLCbOEcuUuT9Ej dCeIn5feK77vgItmKq2vzamDDtGG77fVCU1wdjUybuY02M+t9Iy+eu/lNUlwXg7o87hx fU2oyukpZjE7WjVoGer1QvkHq6h5Mq0u0tKJY3ODpq4sN83WgLrf7XQNdGkF7wu2S/JI pJUQ== X-Gm-Message-State: ALQs6tC7rrB0GRKK72o9RK2GvmlYG/c9qeqwfLKe8lnJKGuy5v5N0vA8 9B42MQpTK7MyWYw6Ol99R+0PzA== X-Google-Smtp-Source: AIpwx4+x7bhcTsT22lBny4aT8l397bZZmvJ5gDDpDnXt9gLHCcHUjh3H+gyaHX1pma1wcvcxISm3zA== X-Received: by 2002:a17:902:205:: with SMTP id 5-v6mr13846453plc.301.1524328899992; Sat, 21 Apr 2018 09:41:39 -0700 (PDT) Received: from monster-08.mvlab.cumulusnetworks.com. (fw.cumulusnetworks.com. [216.129.126.126]) by smtp.googlemail.com with ESMTPSA id e4sm16873563pfa.128.2018.04.21.09.41.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 21 Apr 2018 09:41:39 -0700 (PDT) From: Roopa Prabhu X-Google-Original-From: Roopa Prabhu To: davem@davemloft.net Cc: netdev@vger.kernel.org, dsa@cumulusnetworks.com, idosch@idosch.org Subject: [PATCH net-next v2 0/2] fib rules extack support Date: Sat, 21 Apr 2018 09:41:29 -0700 Message-Id: <1524328891-3647-1-git-send-email-roopa@cumulusnetworks.com> X-Mailer: git-send-email 2.1.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roopa Prabhu First patch refactors code to move fib rule netlink handling into a common function. This became obvious when adding duplicate extack msgs in add and del paths. Second patch adds extack msgs. v2 - Dropped the ip route get support and selftests from the series to look at the input path some more (as pointed out by ido). Will come back to that next week when i have some time. resending just the extack part for now. Roopa Prabhu (2): fib_rules: move common handling of newrule delrule msgs into fib_nl2rule net: fib_rules: add extack support include/net/fib_rules.h | 3 +- net/core/fib_rules.c | 471 +++++++++++++++++++++++------------------------- net/decnet/dn_rules.c | 7 +- net/ipv4/fib_rules.c | 7 +- net/ipv4/ipmr.c | 3 +- net/ipv6/fib6_rules.c | 7 +- net/ipv6/ip6mr.c | 3 +- 7 files changed, 245 insertions(+), 256 deletions(-)