mbox series

[RFC,00/10] PTP support for DSA and mv88e6xxx driver.

Message ID 1517694016-6692-1-git-send-email-andrew@lunn.ch
Headers show
Series PTP support for DSA and mv88e6xxx driver. | expand

Message

Andrew Lunn Feb. 3, 2018, 9:40 p.m. UTC 
This patchset adds support for using the PTP hardware in switches
supported by the mv88e6xxx driver. The code was produces in
collaboration with Brandon Streiff doing the initial implementation,
and then Richard Cochran and Andrew Lunn making further changes and
cleanups.

The code is sufficient to use ptp4l on a single DSA interface, either
as a master or a slave. Due to the use of an MDIO bus to access the
switch, reading hardware timestamps is slower than what ptp4l
expects. Thus it is necessary to use the option
--tx_timestamp_timeout=32. Heavy use of ethtool -S, or bridge fdb show
can also upset ptp4l. Patches to address this will follow.

Further work is requires to support bridges using Boundary Clock or
Transparent Clock mode.

Since netdev is closed at the moment, i'm seeking comments from other
DSA driver writers if the common infrastructure added here will work
for other switches which DSA support.

Thanks
	Andrew


Andrew Lunn (1):
  net: ptp: Add stub for ptp_classify_raw()

Brandon Streiff (9):
  net: dsa: mv88e6xxx: export g2 register accessors
  net: dsa: mv88e6xxx: add accessors for PTP/TAI registers
  net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock
  net: dsa: mv88e6xxx: add support for GPIO configuration
  net: dsa: mv88e6xxx: add support for event capture
  net: dsa: forward hardware timestamping ioctls to switch driver
  net: dsa: forward timestamping callbacks to switch drivers
  net: dsa: mv88e6xxx: add rx/tx timestamping support
  net: dsa: mv88e6xxx: add workaround for 6341 timestamping

 drivers/net/dsa/mv88e6xxx/Kconfig           |  10 +
 drivers/net/dsa/mv88e6xxx/Makefile          |   4 +
 drivers/net/dsa/mv88e6xxx/chip.c            |  67 ++++
 drivers/net/dsa/mv88e6xxx/chip.h            | 103 +++++
 drivers/net/dsa/mv88e6xxx/global2.c         |   9 +-
 drivers/net/dsa/mv88e6xxx/global2.h         |  85 +++-
 drivers/net/dsa/mv88e6xxx/global2_avb.c     | 193 +++++++++
 drivers/net/dsa/mv88e6xxx/global2_scratch.c | 240 ++++++++++++
 drivers/net/dsa/mv88e6xxx/hwtstamp.c        | 584 ++++++++++++++++++++++++++++
 drivers/net/dsa/mv88e6xxx/hwtstamp.h        | 172 ++++++++
 drivers/net/dsa/mv88e6xxx/ptp.c             | 380 ++++++++++++++++++
 drivers/net/dsa/mv88e6xxx/ptp.h             | 108 +++++
 include/linux/ptp_classify.h                |   4 +
 include/net/dsa.h                           |  20 +
 net/dsa/dsa.c                               |  36 ++
 net/dsa/slave.c                             |  59 +++
 16 files changed, 2069 insertions(+), 5 deletions(-)
 create mode 100644 drivers/net/dsa/mv88e6xxx/global2_avb.c
 create mode 100644 drivers/net/dsa/mv88e6xxx/global2_scratch.c
 create mode 100644 drivers/net/dsa/mv88e6xxx/hwtstamp.c
 create mode 100644 drivers/net/dsa/mv88e6xxx/hwtstamp.h
 create mode 100644 drivers/net/dsa/mv88e6xxx/ptp.c
 create mode 100644 drivers/net/dsa/mv88e6xxx/ptp.h

Comments

Brandon Streiff Feb. 6, 2018, 7:44 p.m. UTC | #1 
On 2/3/2018 3:40 PM, Andrew Lunn wrote:
> This patchset adds support for using the PTP hardware in switches
> supported by the mv88e6xxx driver. The code was produces in
> collaboration with Brandon Streiff doing the initial implementation,
> and then Richard Cochran and Andrew Lunn making further changes and
> cleanups.
> 
> ...

With regard to the updates that you and Richard have made to my
initial patchset:

Acked-by: Brandon Streiff <brandon.streiff@ni.com>

Thank you for getting these into a more polished form.

-- brandon