mbox series

[iproute2,0/4] ip/tunnel: Minor cleanups and improvements

Message ID 1516380243-32568-1-git-send-email-serhe.popovych@gmail.com
Headers show
Series ip/tunnel: Minor cleanups and improvements | expand

Message

Serhey Popovych Jan. 19, 2018, 4:43 p.m. UTC 
It is small series of fixes and code cleanups:

  1) Add space after encap-[ds]port parameter value
     in tunnel encapsulation options output.

  2) Unify ttl/hoplimit parsing routines by using
     get_u8(), handling "inherit" and "hlim" as
     alias to "hoplimit" and "ttl" parameter name.

  3) Report when unable to resolve vti tunnel link
     instead of silently quitting and use __u32
     for fwmark istead of unsigned int to match
     with rest of tunneling code.

  4) Use ll_name_to_index() instead of if_nametoindex()
     to make ip(8) output and input parameter acceptance
     coherent.

See individual patch description message for details.

Thanks,
Serhii

Serhey Popovych (4):
  tunnel: Add space between encap-dport and encap-sport in non-JSON
    output
  iptnl/ip6tnl: Unify ttl/hoplimit parsing routines
  vti/vti6: Minor improvements
  iplink: Use ll_name_to_index() instead of if_nametoindex()

 bridge/fdb.c          |    4 ++--
 bridge/mdb.c          |    2 +-
 bridge/vlan.c         |    2 +-
 ip/iplink_bond.c      |    4 ++--
 ip/iplink_bridge.c    |    2 +-
 ip/iplink_vxlan.c     |    2 +-
 ip/iproute_lwtunnel.c |    4 ++--
 ip/link_gre.c         |   12 ++++--------
 ip/link_gre6.c        |   15 ++++++++-------
 ip/link_ip6tnl.c      |   16 ++++++++--------
 ip/link_iptnl.c       |    5 +++--
 ip/link_vti.c         |    4 ++--
 ip/link_vti6.c        |    8 +++++---
 ip/tunnel.c           |    4 ++--
 14 files changed, 42 insertions(+), 42 deletions(-)

Comments

Stephen Hemminger Jan. 23, 2018, 10:52 p.m. UTC | #1 
On Fri, 19 Jan 2018 18:43:59 +0200
Serhey Popovych <serhe.popovych@gmail.com> wrote:

> It is small series of fixes and code cleanups:
> 
>   1) Add space after encap-[ds]port parameter value
>      in tunnel encapsulation options output.
> 
>   2) Unify ttl/hoplimit parsing routines by using
>      get_u8(), handling "inherit" and "hlim" as
>      alias to "hoplimit" and "ttl" parameter name.
> 
>   3) Report when unable to resolve vti tunnel link
>      instead of silently quitting and use __u32
>      for fwmark istead of unsigned int to match
>      with rest of tunneling code.
> 
>   4) Use ll_name_to_index() instead of if_nametoindex()
>      to make ip(8) output and input parameter acceptance
>      coherent.
> 
> See individual patch description message for details.
> 
> Thanks,
> Serhii
> 
> Serhey Popovych (4):
>   tunnel: Add space between encap-dport and encap-sport in non-JSON
>     output
>   iptnl/ip6tnl: Unify ttl/hoplimit parsing routines
>   vti/vti6: Minor improvements
>   iplink: Use ll_name_to_index() instead of if_nametoindex()
> 
>  bridge/fdb.c          |    4 ++--
>  bridge/mdb.c          |    2 +-
>  bridge/vlan.c         |    2 +-
>  ip/iplink_bond.c      |    4 ++--
>  ip/iplink_bridge.c    |    2 +-
>  ip/iplink_vxlan.c     |    2 +-
>  ip/iproute_lwtunnel.c |    4 ++--
>  ip/link_gre.c         |   12 ++++--------
>  ip/link_gre6.c        |   15 ++++++++-------
>  ip/link_ip6tnl.c      |   16 ++++++++--------
>  ip/link_iptnl.c       |    5 +++--
>  ip/link_vti.c         |    4 ++--
>  ip/link_vti6.c        |    8 +++++---
>  ip/tunnel.c           |    4 ++--
>  14 files changed, 42 insertions(+), 42 deletions(-)

Looks good, applied.