| Message ID | 1513756630-14639-1-git-send-email-serhe.popovych@gmail.com |
|---|---|
| Headers | show |
| Series | ip/tunnel: Do not free() answer on rtnl_talk() error, correct ip6gre | expand |
On Wed, 20 Dec 2017 09:57:08 +0200 Serhey Popovych <serhe.popovych@gmail.com> wrote: > In this series I present next set of improvements/fixes: > > 1) If rtnl_talk(), called with answer != NULL fails it > never returns with allocated answer: no need to > initialize answer and free() it in the caller on error. > > 2) Correct ip6gre print endpoint address printing with > ll_addr_n2a(): endpoints are IPv6 addresses, not hex > dump. > > See individual patch description message for details. > > Thanks, > Serhii > > Serhey Popovych (2): > utils: ll_addr: Handle ARPHRD_IP6GRE in ll_addr_n2a() > ip/tunnel: No need to free answer after rtnl_talk() on error > > ip/link_gre.c | 3 +-- > ip/link_gre6.c | 3 +-- > ip/link_ip6tnl.c | 3 +-- > ip/link_iptnl.c | 3 +-- > ip/link_vti.c | 3 +-- > ip/link_vti6.c | 3 +-- > lib/ll_addr.c | 3 ++- > 7 files changed, 8 insertions(+), 13 deletions(-) > Applied, thanks.
In this series I present next set of improvements/fixes: 1) If rtnl_talk(), called with answer != NULL fails it never returns with allocated answer: no need to initialize answer and free() it in the caller on error. 2) Correct ip6gre print endpoint address printing with ll_addr_n2a(): endpoints are IPv6 addresses, not hex dump. See individual patch description message for details. Thanks, Serhii Serhey Popovych (2): utils: ll_addr: Handle ARPHRD_IP6GRE in ll_addr_n2a() ip/tunnel: No need to free answer after rtnl_talk() on error ip/link_gre.c | 3 +-- ip/link_gre6.c | 3 +-- ip/link_ip6tnl.c | 3 +-- ip/link_iptnl.c | 3 +-- ip/link_vti.c | 3 +-- ip/link_vti6.c | 3 +-- lib/ll_addr.c | 3 ++- 7 files changed, 8 insertions(+), 13 deletions(-)