mbox series

[net-next,0/7] Rewrite some existing functionality

Message ID 1507695456-17051-1-git-send-email-subashab@codeaurora.org
Headers show
Series Rewrite some existing functionality | expand

Message

Subash Abhinov Kasiviswanathan Oct. 11, 2017, 4:17 a.m. UTC
This series fixes some of the broken rmnet functionality.
Bridge mode is re-written and made useable and the muxed_ep is converted to hlist.

Patches 1-5 are cleanups in preparation for these changes.
Patch 6 does the hlist conversion.
Patch 7 has the implementation of the rmnet bridge mode.

Subash Abhinov Kasiviswanathan (7):
  net: qualcomm: rmnet: Remove existing logic for bridge mode
  net: qualcomm: rmnet: Remove some unused defines
  net: qualcomm: rmnet: Move rmnet_mode to rmnet_port
  net: qualcomm: rmnet: Remove duplicate setting of rmnet private info
  net: qualcomm: rmnet: Remove duplicate setting of rmnet_devices
  net: qualcomm: rmnet: Convert the muxed endpoint to hlist
  net: qualcomm: rmnet: Implement bridge mode

 drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 166 ++++++++++++++++-----
 drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h |  19 +--
 .../net/ethernet/qualcomm/rmnet/rmnet_handlers.c   | 131 ++++++----------
 .../net/ethernet/qualcomm/rmnet/rmnet_handlers.h   |   3 +-
 .../ethernet/qualcomm/rmnet/rmnet_map_command.c    |   4 +-
 .../net/ethernet/qualcomm/rmnet/rmnet_private.h    |   8 -
 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c    |  36 ++---
 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.h    |   7 +-
 8 files changed, 204 insertions(+), 170 deletions(-)

Comments

David Miller Oct. 11, 2017, 10:22 p.m. UTC | #1
From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Date: Tue, 10 Oct 2017 22:17:29 -0600

> This series fixes some of the broken rmnet functionality.
> Bridge mode is re-written and made useable and the muxed_ep is converted to hlist.
> 
> Patches 1-5 are cleanups in preparation for these changes.
> Patch 6 does the hlist conversion.
> Patch 7 has the implementation of the rmnet bridge mode.

Series applied, thank you.
David Miller Oct. 11, 2017, 10:25 p.m. UTC | #2
From: David Miller <davem@davemloft.net>

Date: Wed, 11 Oct 2017 15:22:59 -0700 (PDT)

> From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>

> Date: Tue, 10 Oct 2017 22:17:29 -0600

> 

>> This series fixes some of the broken rmnet functionality.

>> Bridge mode is re-written and made useable and the muxed_ep is converted to hlist.

>> 

>> Patches 1-5 are cleanups in preparation for these changes.

>> Patch 6 does the hlist conversion.

>> Patch 7 has the implementation of the rmnet bridge mode.

> 

> Series applied, thank you.


Actually, I reverted:

drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c: In function ‘rmnet_rx_handler’:
drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:174:6: warning: ‘rc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  int rc;
      ^~

Also, the indentation of the switch statement is wrong, the break
statements need to be indented the same as the rest of the code
in their switch statements.
Subash Abhinov Kasiviswanathan Oct. 11, 2017, 11:11 p.m. UTC | #3
On 2017-10-11 16:25, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 11 Oct 2017 15:22:59 -0700 (PDT)
> 
>> From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
>> Date: Tue, 10 Oct 2017 22:17:29 -0600
>> 
>>> This series fixes some of the broken rmnet functionality.
>>> Bridge mode is re-written and made useable and the muxed_ep is 
>>> converted to hlist.
>>> 
>>> Patches 1-5 are cleanups in preparation for these changes.
>>> Patch 6 does the hlist conversion.
>>> Patch 7 has the implementation of the rmnet bridge mode.
>> 
>> Series applied, thank you.
> 
> Actually, I reverted:
> 
> drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c: In function
> ‘rmnet_rx_handler’:
> drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:174:6: warning:
> ‘rc’ may be used uninitialized in this function
> [-Wmaybe-uninitialized]
>   int rc;
>       ^~
> 
> Also, the indentation of the switch statement is wrong, the break
> statements need to be indented the same as the rest of the code
> in their switch statements.

Hi David

I'll fix this and upload v2.
Somehow my compiler didnt throw this warning even though i have -Wall 
set.