Message ID | 1507695456-17051-1-git-send-email-subashab@codeaurora.org |
---|---|
Headers | show |
Series | Rewrite some existing functionality | expand |
From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> Date: Tue, 10 Oct 2017 22:17:29 -0600 > This series fixes some of the broken rmnet functionality. > Bridge mode is re-written and made useable and the muxed_ep is converted to hlist. > > Patches 1-5 are cleanups in preparation for these changes. > Patch 6 does the hlist conversion. > Patch 7 has the implementation of the rmnet bridge mode. Series applied, thank you.
From: David Miller <davem@davemloft.net> Date: Wed, 11 Oct 2017 15:22:59 -0700 (PDT) > From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> > Date: Tue, 10 Oct 2017 22:17:29 -0600 > >> This series fixes some of the broken rmnet functionality. >> Bridge mode is re-written and made useable and the muxed_ep is converted to hlist. >> >> Patches 1-5 are cleanups in preparation for these changes. >> Patch 6 does the hlist conversion. >> Patch 7 has the implementation of the rmnet bridge mode. > > Series applied, thank you. Actually, I reverted: drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c: In function ‘rmnet_rx_handler’: drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:174:6: warning: ‘rc’ may be used uninitialized in this function [-Wmaybe-uninitialized] int rc; ^~ Also, the indentation of the switch statement is wrong, the break statements need to be indented the same as the rest of the code in their switch statements.
On 2017-10-11 16:25, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Wed, 11 Oct 2017 15:22:59 -0700 (PDT) > >> From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> >> Date: Tue, 10 Oct 2017 22:17:29 -0600 >> >>> This series fixes some of the broken rmnet functionality. >>> Bridge mode is re-written and made useable and the muxed_ep is >>> converted to hlist. >>> >>> Patches 1-5 are cleanups in preparation for these changes. >>> Patch 6 does the hlist conversion. >>> Patch 7 has the implementation of the rmnet bridge mode. >> >> Series applied, thank you. > > Actually, I reverted: > > drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c: In function > ‘rmnet_rx_handler’: > drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:174:6: warning: > ‘rc’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > int rc; > ^~ > > Also, the indentation of the switch statement is wrong, the break > statements need to be indented the same as the rest of the code > in their switch statements. Hi David I'll fix this and upload v2. Somehow my compiler didnt throw this warning even though i have -Wall set.