diff mbox series

Re: [PATCH v4] mptcp: fix option length of mp_capable syn/ack

Message ID f921f034-33a7-7460-cc85-8e82f1b673f4@tessares.net
State Accepted, archived
Delegated to: Matthieu Baerts
Headers show
Series Re: [PATCH v4] mptcp: fix option length of mp_capable syn/ack | expand

Commit Message

Matthieu Baerts Dec. 6, 2019, 4:13 p.m. UTC 
Hi Davide, Peter,

On 05/12/2019 19:14, Peter Krystad wrote:
> 
> Looks good.

Thank you for the new version and the review!

- 40c5aac59cf7: "squashed" part 1 in "mptcp: Handle MPTCP TCP options"
- 29710f885028: "Signed-off-by" + "Co-developed-by"
- 36e93ae12137: "squashed" part 2 in "mptcp: Create SUBFLOW socket for 
incoming connections"
- cab89c119b1c: conflict in 
t/mptcp-parse-and-emit-MP_CAPABLE-option-according-to-v1-spec
- in this commit, for mptcp_synack_options(), only this change was left 
over:

===

         }

===

I then undo this change. That's also the only change we can see as a 
result (as expected): 7e9aa2a662bf..7c57362bfddb

Tests and re-creation of the 'export' branch is in progress.

Cheers,
Matt
diff mbox series

Patch

diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index 701b6243c377..da94c263197a 100644
--- a/net/mptcp/options.c
+++ b/net/mptcp/options.c
@@ -476,7 +476,7 @@  bool mptcp_synack_options(const struct request_sock 
*req, unsigned int *size,
                 opts->suboptions = OPTION_MPTCP_MPC_SYNACK;
                 opts->sndr_key = subflow_req->local_key;
                 *size = TCPOLEN_MPTCP_MPC_SYNACK;
-               pr_debug("subflow_req=%p, local_key=%llu",
+               pr_debug("req=%p, local_key=%llu",
                          subflow_req, subflow_req->local_key);
                 return true;