| Message ID | f7855857470b26fdbebcfe4adf1cd4779852f7ff.1599115178.git.viresh.kumar@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] syscalls: select: Merge few tests and migrate to new format | expand |
Hi Viresh IMO, we don't need to rename select04 to select02. The later new case can use select02 name. It makes select history more clean. Best Regards Yang Xu > Do the rename. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > runtest/quickhit | 2 +- > runtest/syscalls | 2 +- > testcases/kernel/syscalls/select/.gitignore | 2 +- > testcases/kernel/syscalls/select/{select04.c => select02.c} | 0 > 4 files changed, 3 insertions(+), 3 deletions(-) > rename testcases/kernel/syscalls/select/{select04.c => select02.c} (100%) > > diff --git a/runtest/quickhit b/runtest/quickhit > index c01dc4f30b9f..9ada4c4c47c2 100644 > --- a/runtest/quickhit > +++ b/runtest/quickhit > @@ -180,7 +180,7 @@ sbrk01 sbrk01 > # Basic test for sbrk(2) > select01 select01 > # Basic select tests > -select04 select04 > +select02 select02 > setgid01 setgid01 > # Basic test for setgid(2) > setpgid01 setpgid01 > diff --git a/runtest/syscalls b/runtest/syscalls > index 105ca29dd29b..0c6bf0e4d0a7 100644 > --- a/runtest/syscalls > +++ b/runtest/syscalls > @@ -1150,7 +1150,7 @@ sched_getattr01 sched_getattr01 > sched_getattr02 sched_getattr02 > > select01 select01 > -select04 select04 > +select02 select02 > > semctl01 semctl01 > semctl02 semctl02 > diff --git a/testcases/kernel/syscalls/select/.gitignore b/testcases/kernel/syscalls/select/.gitignore > index 243a092ac6ca..f5a43c23326a 100644 > --- a/testcases/kernel/syscalls/select/.gitignore > +++ b/testcases/kernel/syscalls/select/.gitignore > @@ -1,2 +1,2 @@ > /select01 > -/select04 > +/select02 > diff --git a/testcases/kernel/syscalls/select/select04.c b/testcases/kernel/syscalls/select/select02.c > similarity index 100% > rename from testcases/kernel/syscalls/select/select04.c > rename to testcases/kernel/syscalls/select/select02.c >
On 08-09-20, 15:39, Yang Xu wrote: > Hi Viresh > > IMO, we don't need to rename select04 to select02. The later new case can > use select02 name. It makes select history more clean. Why keeping such history is important ? I think it will look rather confusing why we have files named as 01 and then 04. Anyway, I will keep the patch in the series and will leave it for Cyril to decide if he wants to pick the patch or not. Thanks Yang.
diff --git a/runtest/quickhit b/runtest/quickhit index c01dc4f30b9f..9ada4c4c47c2 100644 --- a/runtest/quickhit +++ b/runtest/quickhit @@ -180,7 +180,7 @@ sbrk01 sbrk01 # Basic test for sbrk(2) select01 select01 # Basic select tests -select04 select04 +select02 select02 setgid01 setgid01 # Basic test for setgid(2) setpgid01 setpgid01 diff --git a/runtest/syscalls b/runtest/syscalls index 105ca29dd29b..0c6bf0e4d0a7 100644 --- a/runtest/syscalls +++ b/runtest/syscalls @@ -1150,7 +1150,7 @@ sched_getattr01 sched_getattr01 sched_getattr02 sched_getattr02 select01 select01 -select04 select04 +select02 select02 semctl01 semctl01 semctl02 semctl02 diff --git a/testcases/kernel/syscalls/select/.gitignore b/testcases/kernel/syscalls/select/.gitignore index 243a092ac6ca..f5a43c23326a 100644 --- a/testcases/kernel/syscalls/select/.gitignore +++ b/testcases/kernel/syscalls/select/.gitignore @@ -1,2 +1,2 @@ /select01 -/select04 +/select02 diff --git a/testcases/kernel/syscalls/select/select04.c b/testcases/kernel/syscalls/select/select02.c similarity index 100% rename from testcases/kernel/syscalls/select/select04.c rename to testcases/kernel/syscalls/select/select02.c
Do the rename. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- runtest/quickhit | 2 +- runtest/syscalls | 2 +- testcases/kernel/syscalls/select/.gitignore | 2 +- testcases/kernel/syscalls/select/{select04.c => select02.c} | 0 4 files changed, 3 insertions(+), 3 deletions(-) rename testcases/kernel/syscalls/select/{select04.c => select02.c} (100%)