diff mbox series

[v2] Add rename15 test

Message ID 20240424092357.11207-1-andrea.cervesato@suse.de
State New
Headers show
Series [v2] Add rename15 test | expand

Commit Message

Andrea Cervesato April 24, 2024, 9:23 a.m. UTC 
From: Andrea Cervesato <andrea.cervesato@suse.com>

This test has been extracted from symlink01 and it verifies that
rename() is working correctly on symlink() generated files, renaming
symbolic link and checking if stat() information are preserved.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
Added 2 more tests
* Test rename() on symlink pointing to a non-existent path
* Test rename() on symlink pointing to a path created lately

Usage of macros for file names
Resolve tmpdir memory leakage

 runtest/smoketest                           |   2 +-
 runtest/syscalls                            |   2 +-
 testcases/kernel/syscalls/rename/.gitignore |   1 +
 testcases/kernel/syscalls/rename/rename15.c | 100 ++++++++++++++++++++
 4 files changed, 103 insertions(+), 2 deletions(-)
 create mode 100644 testcases/kernel/syscalls/rename/rename15.c
diff mbox series

Patch

diff --git a/runtest/smoketest b/runtest/smoketest
index 83eebfe7b..19fa257d6 100644
--- a/runtest/smoketest
+++ b/runtest/smoketest
@@ -10,7 +10,7 @@  write01 write01
 symlink01 symlink01
 stat04 symlink01 -T stat04
 utime01A symlink01 -T utime01
-rename01A symlink01 -T rename01
+rename15 rename15
 splice02 splice02 -s 20
 df01_sh df01.sh
 shell_test01 echo "SUCCESS" | shell_pipe01.sh
diff --git a/runtest/syscalls b/runtest/syscalls
index b9dd9fec6..f515d46aa 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -1156,7 +1156,6 @@  removexattr01 removexattr01
 removexattr02 removexattr02
 
 rename01 rename01
-rename01A symlink01 -T rename01
 rename03 rename03
 rename04 rename04
 rename05 rename05
@@ -1169,6 +1168,7 @@  rename11 rename11
 rename12 rename12
 rename13 rename13
 rename14 rename14
+rename15 rename15
 
 #renameat test cases
 renameat01 renameat01
diff --git a/testcases/kernel/syscalls/rename/.gitignore b/testcases/kernel/syscalls/rename/.gitignore
index f95cf7d21..d17b80f09 100644
--- a/testcases/kernel/syscalls/rename/.gitignore
+++ b/testcases/kernel/syscalls/rename/.gitignore
@@ -11,3 +11,4 @@ 
 /rename12
 /rename13
 /rename14
+/rename15
diff --git a/testcases/kernel/syscalls/rename/rename15.c b/testcases/kernel/syscalls/rename/rename15.c
new file mode 100644
index 000000000..d410758a2
--- /dev/null
+++ b/testcases/kernel/syscalls/rename/rename15.c
@@ -0,0 +1,100 @@ 
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
+ *    Author: David Fenner
+ *    Copilot: Jon Hendrickson
+ * Copyright (C) 2024 Andrea Cervesato andrea.cervesato@suse.com
+ */
+
+/*\
+ * [Description]
+ *
+ * This test verifies that rename() is working correctly on symlink()
+ * generated files.
+ */
+
+#include <stdlib.h>
+#include "tst_test.h"
+
+#define OLDNAME "msymlink0"
+#define NEWNAME "asymlink0"
+
+static char *tmpdir;
+
+static void test_existing(void)
+{
+	tst_res(TINFO, "Test rename() on symlink pointing to an existent path");
+
+	struct stat oldsym_stat;
+	struct stat newsym_stat;
+
+	SAFE_SYMLINK(tmpdir, OLDNAME);
+	SAFE_STAT(OLDNAME, &oldsym_stat);
+
+	SAFE_RENAME(OLDNAME, NEWNAME);
+	SAFE_STAT(NEWNAME, &newsym_stat);
+
+	TST_EXP_EQ_LI(oldsym_stat.st_ino, newsym_stat.st_ino);
+	TST_EXP_EQ_LI(oldsym_stat.st_dev, newsym_stat.st_dev);
+
+	SAFE_UNLINK(NEWNAME);
+}
+
+static void test_non_existing(void)
+{
+	tst_res(TINFO, "Test rename() on symlink pointing to a non-existent path");
+
+	struct stat path_stat;
+
+	SAFE_SYMLINK("this_path_doesnt_exist", OLDNAME);
+	TST_EXP_FAIL(stat(OLDNAME, &path_stat), ENOENT);
+
+	SAFE_RENAME(OLDNAME, NEWNAME);
+	TST_EXP_FAIL(stat(NEWNAME, &path_stat), ENOENT);
+
+	SAFE_UNLINK(NEWNAME);
+}
+
+static void test_creat(void)
+{
+	tst_res(TINFO, "Test rename() on symlink pointing to a path created lately");
+
+	char *objpath = "object";
+	struct stat path_stat;
+
+	SAFE_SYMLINK(objpath, OLDNAME);
+	TST_EXP_FAIL(stat(OLDNAME, &path_stat), ENOENT);
+
+	tst_res(TINFO, "Create object file");
+
+	SAFE_CREAT(objpath, 0700);
+	SAFE_RENAME(OLDNAME, NEWNAME);
+	TST_EXP_PASS(stat(NEWNAME, &path_stat));
+
+	SAFE_UNLINK(objpath);
+	SAFE_UNLINK(NEWNAME);
+}
+
+static void run(void)
+{
+	test_existing();
+	test_creat();
+	test_non_existing();
+}
+
+static void setup(void)
+{
+	tmpdir = tst_get_tmpdir();
+}
+
+static void cleanup(void)
+{
+	free(tmpdir);
+}
+
+static struct tst_test test = {
+	.setup = setup,
+	.cleanup = cleanup,
+	.test_all = run,
+	.needs_tmpdir = 1,
+};