diff mbox series

[v1] zram01.sh: Increase timeout for check_read_mem_used_total

Message ID 20240411044645.29938-1-wegao@suse.com
State New
Headers show
Series [v1] zram01.sh: Increase timeout for check_read_mem_used_total | expand

Commit Message

Wei Gao April 11, 2024, 4:46 a.m. UTC
Increase timeout value to let case pass on our low ppc64le
machine.

Signed-off-by: Wei Gao <wegao@suse.com>
---
 testcases/kernel/device-drivers/zram/zram01.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Petr Vorel April 18, 2024, 2:22 p.m. UTC | #1
Hi all,

> Increase timeout value to let case pass on our low ppc64le
nit: s/low/low resource/
> machine.

> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
>  testcases/kernel/device-drivers/zram/zram01.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
> index 0c100b706..959dab217 100755
> --- a/testcases/kernel/device-drivers/zram/zram01.sh
> +++ b/testcases/kernel/device-drivers/zram/zram01.sh
> @@ -155,7 +155,7 @@ zram_fill_fs()
>  			continue
>  		fi

> -		TST_RETRY_FUNC "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0
> +		TST_RETRY_FN_EXP_BACKOFF "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0 10

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Sounds ok for me to avoid timeout.
@Cyril, @Li WDYT? Or do you smell bug we try to cover?

Kind regards,
Petr

>  		mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
>  		tst_res TINFO "mem_used_total: $mem_used_total"
diff mbox series

Patch

diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
index 0c100b706..959dab217 100755
--- a/testcases/kernel/device-drivers/zram/zram01.sh
+++ b/testcases/kernel/device-drivers/zram/zram01.sh
@@ -155,7 +155,7 @@  zram_fill_fs()
 			continue
 		fi
 
-		TST_RETRY_FUNC "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0
+		TST_RETRY_FN_EXP_BACKOFF "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0 10
 		mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
 		tst_res TINFO "mem_used_total: $mem_used_total"