| Message ID | 20240130073507.662414-2-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | runtest cleanup | expand |
Hi! > Move cap_bounds content to syscalls > > runtest/cap_bounds and runtest/filecaps had both only single entry. > That's a waste of starting SUT, therefore create new runtest file > capability and move it there. Add there also runtest/securebits. > > Signed-off-by: Petr Vorel <pvorel@suse.cz> Reviewed-by: Cyril Hrubis <chrubis@suse.cz> > --- > Maybe it'd be safer to verify if the tests are still relevant now. > Because name is more promising than the actual content :). > Also we have other tests which use libcap. > Alternatively, we could just move them to syscalls. I would just merge them for now, since it's better than having one or two tests per file.
Hi Cyril, > Hi! > > Move cap_bounds content to syscalls > > runtest/cap_bounds and runtest/filecaps had both only single entry. > > That's a waste of starting SUT, therefore create new runtest file > > capability and move it there. Add there also runtest/securebits. > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > Reviewed-by: Cyril Hrubis <chrubis@suse.cz> > > --- > > Maybe it'd be safer to verify if the tests are still relevant now. > > Because name is more promising than the actual content :). > > Also we have other tests which use libcap. > > Alternatively, we could just move them to syscalls. > I would just merge them for now, since it's better than having one or > two tests per file. Right, merged this and 2nd patch. Thanks for your review! Kind regards, Petr
diff --git a/runtest/cap_bounds b/runtest/cap_bounds deleted file mode 100644 index 518d1e3ab..000000000 --- a/runtest/cap_bounds +++ /dev/null @@ -1,2 +0,0 @@ -#DESCRIPTION:Posix capability bounding set -Cap_bounds run_capbounds.sh diff --git a/runtest/securebits b/runtest/capability similarity index 53% rename from runtest/securebits rename to runtest/capability index 64e6e0a0d..c7af1235e 100644 --- a/runtest/securebits +++ b/runtest/capability @@ -1,4 +1,7 @@ -#DESCRIPTION:securebits tests +# various capability related tests +cap_bounds run_capbounds.sh +filecaps filecapstest.sh + check_keepcaps01 check_keepcaps 1 check_keepcaps02 check_keepcaps 2 check_keepcaps03 check_keepcaps 3 diff --git a/runtest/filecaps b/runtest/filecaps deleted file mode 100644 index 1872c0bc5..000000000 --- a/runtest/filecaps +++ /dev/null @@ -1,2 +0,0 @@ -#DESCRIPTION:file capabilities -Filecaps filecapstest.sh
Move cap_bounds content to syscalls runtest/cap_bounds and runtest/filecaps had both only single entry. That's a waste of starting SUT, therefore create new runtest file capability and move it there. Add there also runtest/securebits. Signed-off-by: Petr Vorel <pvorel@suse.cz> --- Maybe it'd be safer to verify if the tests are still relevant now. Because name is more promising than the actual content :). Also we have other tests which use libcap. Alternatively, we could just move them to syscalls. runtest/cap_bounds | 2 -- runtest/{securebits => capability} | 5 ++++- runtest/filecaps | 2 -- 3 files changed, 4 insertions(+), 5 deletions(-) delete mode 100644 runtest/cap_bounds rename runtest/{securebits => capability} (53%) delete mode 100644 runtest/filecaps