| Message ID | 20240125100009.387096-1-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] fs_fill: Increase timeout to 5 min | expand |
Hi!
Shouldn't this have fixes tag for:
"fs_fill: Increase test loop device size to 1GB"
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> Hi! > Shouldn't this have fixes tag for: > "fs_fill: Increase test loop device size to 1GB" The timeout was during 300 MB, that's why I would not add it. But I can be wrong. I'm not sure if increasing to 1 GB makes test run slightly faster. Maybe device size and runtime are related. Kind regards, Petr > Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Thanks!
Hi! > I'm not sure if increasing to 1 GB makes test run slightly faster. > Maybe device size and runtime are related. Of course it is, the test fills the whole device with data, the runtime should really be a function of the device size.
> Hi! > > I'm not sure if increasing to 1 GB makes test run slightly faster. > > Maybe device size and runtime are related. > Of course it is, the test fills the whole device with data, the runtime > should really be a function of the device size. Right, added and merged. Kind regards, Petr
diff --git a/testcases/kernel/fs/fs_fill/fs_fill.c b/testcases/kernel/fs/fs_fill/fs_fill.c index 325e83643..3b4ee1ae9 100644 --- a/testcases/kernel/fs/fs_fill/fs_fill.c +++ b/testcases/kernel/fs/fs_fill/fs_fill.c @@ -121,7 +121,7 @@ static void cleanup(void) } static struct tst_test test = { - .max_runtime = 60, + .max_runtime = 300, .needs_root = 1, .dev_min_size = 1024, .mount_device = 1,
1 min timeout sometimes is not enough. Although it could be fixed LTP_RUNTIME_MUL=2, let's prolong the default timeout. Signed-off-by: Petr Vorel <pvorel@suse.cz> --- testcases/kernel/fs/fs_fill/fs_fill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)