diff mbox series

[v1] Increase .max_runtime for fsx-linux

Message ID 20240124102359.6656-1-andrea.cervesato@suse.de
State Accepted
Headers show
Series [v1] Increase .max_runtime for fsx-linux | expand

Commit Message

Andrea Cervesato Jan. 24, 2024, 10:23 a.m. UTC 
From: Andrea Cervesato <andrea.cervesato@suse.com>

Sometimes fsx-linux test is timing out on slow systems. We increase its
value to 1800 seconds, so we ensure test won't timeout in most cases.
The value has been choosen according with aio testing suite, which has
1800 seconds timeout and it worked really well so far.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 testcases/kernel/fs/fsx-linux/fsx-linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cyril Hrubis Jan. 24, 2024, 1:06 p.m. UTC | #1 
Hi!
I've added:

Fixes: 176667f40710 ("fsx-linux: Add .max_runtime = 60")

To the commit message and pushed, thanks.
Petr Vorel Jan. 24, 2024, 2:07 p.m. UTC | #2 
> Hi!
> I've added:

The longest run is due:
fsx22 fsx-linux -N 100000

other runs are much faster. I hope that -N 100000 makes sense, because I was
thinking about deleting this test. Because allow test to run for 1 hour can lead
to masive runtime in case of kernel bug which keeps fsx-linux running (22 hours
in worse case).
Yes, 60 sec is too low (-N 100000 runs on my VM 50 sec, which is not much
spare time), but maybe adding just 300 (5 min) or 600 should have been enough
even for -N 100000 (all 21 previous tests run faster).
Don't we want to reconsider smaller value?

> Fixes: 176667f40710 ("fsx-linux: Add .max_runtime = 60")
FYI The first commit which introduce the problem was rewrite into new API
134b08362 ("fs: Rewrite fsx-linux test")

Kind regards,
Petr

> To the commit message and pushed, thanks.
diff mbox series

Patch

diff --git a/testcases/kernel/fs/fsx-linux/fsx-linux.c b/testcases/kernel/fs/fsx-linux/fsx-linux.c
index 32fc70e01..ba1e21bbc 100644
--- a/testcases/kernel/fs/fsx-linux/fsx-linux.c
+++ b/testcases/kernel/fs/fsx-linux/fsx-linux.c
@@ -367,7 +367,7 @@  static struct tst_test test = {
 	.setup = setup,
 	.cleanup = cleanup,
 	.test_all = run,
-	.max_runtime = 60,
+	.max_runtime = 1800,
 	.options = (struct tst_option[]) {
 		{ "l:", &str_file_max_size, "Maximum size in MB of the test file(s) (default 262144)" },
 		{ "o:", &str_op_max_size, "Maximum size for single operation (default 65536)" },