| Message ID | 20240121122959.1386-2-yangx.jy@fujitsu.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/4] syscalls/preadv: Fix docparse | expand |
Hi Xiao Yang, > Also add LTP Copyright. +1 > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> > --- > testcases/kernel/syscalls/preadv/preadv.h | 21 ++++++--------------- > testcases/kernel/syscalls/preadv/preadv01.c | 13 +++++++------ > testcases/kernel/syscalls/preadv/preadv02.c | 7 ++++--- > testcases/kernel/syscalls/preadv/preadv03.c | 1 + > 4 files changed, 18 insertions(+), 24 deletions(-) > diff --git a/testcases/kernel/syscalls/preadv/preadv.h b/testcases/kernel/syscalls/preadv/preadv.h > index 73466a9aa..bfe7e7223 100644 > --- a/testcases/kernel/syscalls/preadv/preadv.h > +++ b/testcases/kernel/syscalls/preadv/preadv.h > @@ -1,18 +1,9 @@ > -/* > -* Copyright (c) 2015 Fujitsu Ltd. > -* Author: Xiao Yang <yangx.jy@cn.fujitsu.com> > -* > -* This program is free software; you can redistribute it and/or modify it > -* under the terms of version 2 of the GNU General Public License as > -* published by the Free Software Foundation. Xiao Yang, you are the author of this. Could you please relicense to GPL v2+ (GPL-2.0-or-later) and state that on the commit message? Otherwise LGTM. Reviewed-by: Petr Vorel <pvorel@suse.cz> Kind regards, Petr
diff --git a/testcases/kernel/syscalls/preadv/preadv.h b/testcases/kernel/syscalls/preadv/preadv.h index 73466a9aa..bfe7e7223 100644 --- a/testcases/kernel/syscalls/preadv/preadv.h +++ b/testcases/kernel/syscalls/preadv/preadv.h @@ -1,18 +1,9 @@ -/* -* Copyright (c) 2015 Fujitsu Ltd. -* Author: Xiao Yang <yangx.jy@cn.fujitsu.com> -* -* This program is free software; you can redistribute it and/or modify it -* under the terms of version 2 of the GNU General Public License as -* published by the Free Software Foundation. -* -* This program is distributed in the hope that it would be useful, but -* WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. -* -* You should have received a copy of the GNU General Public License -* alone with this program. -*/ +/* SPDX-License-Identifier: GPL-2.0 + * + * Copyright (c) 2015 Fujitsu Ltd. + * Author: Xiao Yang <yangx.jy@cn.fujitsu.com> + * Copyright (c) Linux Test Project, 2016-2023 + */ #ifndef PREADV_H #define PREADV_H diff --git a/testcases/kernel/syscalls/preadv/preadv01.c b/testcases/kernel/syscalls/preadv/preadv01.c index 10604200d..871b3ab42 100644 --- a/testcases/kernel/syscalls/preadv/preadv01.c +++ b/testcases/kernel/syscalls/preadv/preadv01.c @@ -1,8 +1,9 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* -* Copyright (c) 2015 Fujitsu Ltd. -* Author: Xiao Yang <yangx.jy@cn.fujitsu.com> -*/ + * Copyright (c) 2015 Fujitsu Ltd. + * Author: Xiao Yang <yangx.jy@cn.fujitsu.com> + * Copyright (c) Linux Test Project, 2016-2023 + */ /*\ * [Description] @@ -38,7 +39,7 @@ static struct tcase { {1, CHUNK*3/2, CHUNK/2, 'b'} }; -void verify_preadv(unsigned int n) +static void verify_preadv(unsigned int n) { int i; char *vec; @@ -81,7 +82,7 @@ void verify_preadv(unsigned int n) "with content '%c' expectedly", tc->size, tc->content); } -void setup(void) +static void setup(void) { char buf[CHUNK]; @@ -94,7 +95,7 @@ void setup(void) SAFE_WRITE(SAFE_WRITE_ALL, fd, buf, sizeof(buf)); } -void cleanup(void) +static void cleanup(void) { if (fd > 0) SAFE_CLOSE(fd); diff --git a/testcases/kernel/syscalls/preadv/preadv02.c b/testcases/kernel/syscalls/preadv/preadv02.c index bfcf5052b..9977a4f48 100644 --- a/testcases/kernel/syscalls/preadv/preadv02.c +++ b/testcases/kernel/syscalls/preadv/preadv02.c @@ -1,8 +1,9 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* -* Copyright (c) 2015-2016 Fujitsu Ltd. -* Author: Xiao Yang <yangx.jy@cn.fujitsu.com> -*/ + * Copyright (c) 2015-2016 Fujitsu Ltd. + * Author: Xiao Yang <yangx.jy@cn.fujitsu.com> + * Copyright (c) Linux Test Project, 2017-2023 + */ /*\ * [Description] diff --git a/testcases/kernel/syscalls/preadv/preadv03.c b/testcases/kernel/syscalls/preadv/preadv03.c index 5d2946bc3..558d85050 100644 --- a/testcases/kernel/syscalls/preadv/preadv03.c +++ b/testcases/kernel/syscalls/preadv/preadv03.c @@ -2,6 +2,7 @@ /* * Copyright (c) 2018 FUJITSU LIMITED. All rights reserved. * Author: Xiao Yang <yangx.jy@cn.fujitsu.com> + * Copyright (c) Linux Test Project, 2019-2023 */ /*\
Also add LTP Copyright. Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> --- testcases/kernel/syscalls/preadv/preadv.h | 21 ++++++--------------- testcases/kernel/syscalls/preadv/preadv01.c | 13 +++++++------ testcases/kernel/syscalls/preadv/preadv02.c | 7 ++++--- testcases/kernel/syscalls/preadv/preadv03.c | 1 + 4 files changed, 18 insertions(+), 24 deletions(-)