diff mbox series

Bug: Handling hugemmap24 test item failure issues

Message ID 20230406095404.181012-1-mengfanhui@kylinos.cn
State Superseded
Headers show
Series Bug: Handling hugemmap24 test item failure issues | expand

Commit Message

mengfanhui April 6, 2023, 9:54 a.m. UTC
Rootcause:
mmap function start parameter overstep the boundary

Solution:
judge longarch64 macros,execute low start address process

Signed-off-by: mengfanhui <mengfanhui@kylinos.cn>
---
 testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Li Wang April 7, 2023, 8:17 a.m. UTC | #1
Hi Fanhui,

What kind of failure did you hit in test?
Can you try with method discussed in this thread:
https://lists.linux.it/pipermail/ltp/2023-March/033168.html


On Thu, Apr 6, 2023 at 6:28 PM mengfanhui <mengfanhui@kylinos.cn> wrote:

> Rootcause:
> mmap function start parameter overstep the boundary
>
> Solution:
> judge longarch64 macros,execute low start address process
>
> Signed-off-by: mengfanhui <mengfanhui@kylinos.cn>
> ---
>  testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c
> b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c
> index a465aadec..40e94a331 100644
> --- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c
> +++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c
> @@ -30,7 +30,7 @@ static int init_slice_boundary(int fd)
>         unsigned long slice_size;
>         void *p, *heap;
>         int i;
> -#if defined(__LP64__) && !defined(__aarch64__)
> +#if defined(__LP64__) && !defined(__aarch64__) && defined(__longarch64__)
>

This is not correct as it might have side effects on other 64bit platform.



>         /* powerpc: 1TB slices starting at 1 TB */
>         slice_boundary = 0x10000000000;
>         slice_size = 0x10000000000;
> --
> 2.25.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>
diff mbox series

Patch

diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c
index a465aadec..40e94a331 100644
--- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c
+++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap24.c
@@ -30,7 +30,7 @@  static int init_slice_boundary(int fd)
 	unsigned long slice_size;
 	void *p, *heap;
 	int i;
-#if defined(__LP64__) && !defined(__aarch64__)
+#if defined(__LP64__) && !defined(__aarch64__) && defined(__longarch64__)
 	/* powerpc: 1TB slices starting at 1 TB */
 	slice_boundary = 0x10000000000;
 	slice_size = 0x10000000000;