| Message ID | 20230111181826.9395-1-wegao@suse.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] Fix coding style issue | expand |
Hi Wei, ... > if (tc->use_overlay && !ovl_mounted) { > tst_res(TCONF, > - "overlayfs is not configured in this kernel."); > + "overlayfs is not configured in this kernel."); This was short enough to put it on the single line. I also removed the dot at the end and merged. Thanks! Kind regards, Petr
Hi Petr Thanks a lot : ) Regards Gao Wei -----Original Message----- From: Petr Vorel <pvorel@suse.cz> Sent: 13 January 2023 18:02 To: Wei Gao <wegao@suse.com> Cc: ltp@lists.linux.it Subject: Re: [LTP] [PATCH v1] Fix coding style issue Hi Wei, ... > if (tc->use_overlay && !ovl_mounted) { > tst_res(TCONF, > - "overlayfs is not configured in this kernel."); > + "overlayfs is not configured in this kernel."); This was short enough to put it on the single line. I also removed the dot at the end and merged. Thanks! Kind regards, Petr
diff --git a/testcases/kernel/syscalls/readahead/readahead02.c b/testcases/kernel/syscalls/readahead/readahead02.c index 3ed88c005..4eef353a8 100644 --- a/testcases/kernel/syscalls/readahead/readahead02.c +++ b/testcases/kernel/syscalls/readahead/readahead02.c @@ -69,7 +69,7 @@ static struct tcase { int use_overlay; int use_fadvise; /* Use either readahead() syscall or POSIX_FADV_WILLNEED */ - int (*readahead)(int, off_t, size_t); + int (*readahead)(int fd, off_t offset, size_t len); } tcases[] = { { "readahead on file", 0, 0, libc_readahead }, { "readahead on overlayfs file", 1, 0, libc_readahead }, @@ -224,7 +224,7 @@ static void test_readahead(unsigned int n) if (tc->use_overlay && !ovl_mounted) { tst_res(TCONF, - "overlayfs is not configured in this kernel."); + "overlayfs is not configured in this kernel."); return; } @@ -252,7 +252,7 @@ static void test_readahead(unsigned int n) cached_low = get_cached_size(); tst_res(TINFO, "read_testfile(1)"); ret = read_testfile(tc, 1, testfile, testfile_size, &read_bytes_ra, - &usec_ra, &cached_ra); + &usec_ra, &cached_ra); if (ret == EINVAL) { if (tc->use_fadvise &&
Signed-off-by: WEI GAO <wegao@suse.com> --- testcases/kernel/syscalls/readahead/readahead02.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)