| Message ID | 20221125123129.102360-3-david@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | security/dirtyc0w_shmem: Two fixes | expand |
Hi all,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Fixes: a46f8956f ("security/dirtyc0w_shmem: Add new test for CVE-2022-2590")
Waiting little bit for Martin's input (not required) before merging.
Kind regards,
Petr
Hi, both patches look good. Reviewed-by: Martin Doucha <mdoucha@suse.cz> On 25. 11. 22 13:31, David Hildenbrand wrote: > Compilation points out that: > testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c: useless tag: > needs_tmpdir > > needs_tmpdir is implied by needs_checkpoints, so we can drop it. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c > index 1e3b194e7..14b8f8317 100644 > --- a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c > +++ b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c > @@ -109,7 +109,6 @@ static struct tst_test test = { > .needs_checkpoints = 1, > .forks_child = 1, > .needs_root = 1, > - .needs_tmpdir = 1, > .max_runtime = 120, > .setup = setup, > .cleanup = cleanup,
Hi Martin, David, > Hi, > both patches look good. Thanks, merged! Kind regards, Petr
diff --git a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c index 1e3b194e7..14b8f8317 100644 --- a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c +++ b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c @@ -109,7 +109,6 @@ static struct tst_test test = { .needs_checkpoints = 1, .forks_child = 1, .needs_root = 1, - .needs_tmpdir = 1, .max_runtime = 120, .setup = setup, .cleanup = cleanup,
Compilation points out that: testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c: useless tag: needs_tmpdir needs_tmpdir is implied by needs_checkpoints, so we can drop it. Signed-off-by: David Hildenbrand <david@redhat.com> --- testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c | 1 - 1 file changed, 1 deletion(-)