diff mbox series

[v2,1/5] ioctl_sg01: Add max_runtime

Message ID 20220914161930.27681-2-mdoucha@suse.cz
State Accepted
Headers show
Series Max_runtime timeout fixes | expand

Commit Message

Martin Doucha Sept. 14, 2022, 4:19 p.m. UTC
Test setup can take very long time depending on the amount of free RAM.
Set high max_runtime to avoid timeout issues.

Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---

Changes since v1:
- Changed max_runtime from unlimited to 1 hour

We'll add .max_setup_runtime after the release to not break even more things.
Let's use this as a temporary fix.

 testcases/kernel/syscalls/ioctl/ioctl_sg01.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Petr Vorel Sept. 14, 2022, 8:27 p.m. UTC | #1
Hi Martin,

> Test setup can take very long time depending on the amount of free RAM.
> Set high max_runtime to avoid timeout issues.

Reviewed-by: Petr Vorel <pvorel@suse.cz>


> Changes since v1:
> - Changed max_runtime from unlimited to 1 hour

> We'll add .max_setup_runtime after the release to not break even more things.
> Let's use this as a temporary fix.
+1

Kind regards,
Petr
Cyril Hrubis Sept. 15, 2022, 11:51 a.m. UTC | #2
Hi!
> Test setup can take very long time depending on the amount of free RAM.
> Set high max_runtime to avoid timeout issues.
> 
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> 
> Changes since v1:
> - Changed max_runtime from unlimited to 1 hour
> 
> We'll add .max_setup_runtime after the release to not break even more things.
> Let's use this as a temporary fix.

Fair enough. Pushed.
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_sg01.c b/testcases/kernel/syscalls/ioctl/ioctl_sg01.c
index 94b30dc6b..dfbba399d 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_sg01.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_sg01.c
@@ -126,6 +126,7 @@  static struct tst_test test = {
 	.test_all = run,
 	.setup = setup,
 	.cleanup = cleanup,
+	.max_runtime = 3600,
 	.tags = (const struct tst_tag[]) {
 		{"linux-git", "a45b599ad808"},
 		{"CVE", "2018-1000204"},