diff mbox series

[2/2] build.sh: Allow specifying additional make options

Message ID 20220817133929.234873-3-tudor.cretu@arm.com
State Rejected
Headers show
Series utils/compat_16: Allow build.sh to disable the compat_16 tests | expand

Commit Message

Tudor Cretu Aug. 17, 2022, 1:39 p.m. UTC
This enables build.sh to use make options such as TST_NEWER_64_SYSCALL or
TST_COMPAT_16_SYSCALL, e.g.:

MAKE_OPTS="TST_NEWER_64_SYSCALL=no TST_COMPAT_16_SYSCALL=no" ./build.sh ...

Signed-off-by: Tudor Cretu <tudor.cretu@arm.com>
---
 build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Palethorpe Oct. 11, 2022, 2:43 p.m. UTC | #1
Hello,

Tudor Cretu <tudor.cretu@arm.com> writes:

> This enables build.sh to use make options such as TST_NEWER_64_SYSCALL or
> TST_COMPAT_16_SYSCALL, e.g.:
>
> MAKE_OPTS="TST_NEWER_64_SYSCALL=no TST_COMPAT_16_SYSCALL=no"
> ./build.sh ...

I'm not sure if you still want this one or not after the other patch was
dropped. In any case Petr seems to favor command line args (with docs)
over env variables. So it would be best to stick to the existing style
of this script.

>
> Signed-off-by: Tudor Cretu <tudor.cretu@arm.com>
> ---
>  build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/build.sh b/build.sh
> index 1767cc21b..42c89ad97 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -18,7 +18,7 @@ CONFIGURE_OPTS_OUT_TREE="--with-realtime-testsuite $CONFIGURE_OPT_EXTRA"
>  SRC_DIR="$(cd $(dirname $0); pwd)"
>  BUILD_DIR="$SRC_DIR/../ltp-build"
>  
> -MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN)"
> +MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN) $MAKE_OPTS"
>  MAKE_OPTS_OUT_TREE="$MAKE_OPTS -C $BUILD_DIR -f $SRC_DIR/Makefile top_srcdir=$SRC_DIR top_builddir=$BUILD_DIR"
>  
>  run_configure()
> -- 
> 2.25.1
diff mbox series

Patch

diff --git a/build.sh b/build.sh
index 1767cc21b..42c89ad97 100755
--- a/build.sh
+++ b/build.sh
@@ -18,7 +18,7 @@  CONFIGURE_OPTS_OUT_TREE="--with-realtime-testsuite $CONFIGURE_OPT_EXTRA"
 SRC_DIR="$(cd $(dirname $0); pwd)"
 BUILD_DIR="$SRC_DIR/../ltp-build"
 
-MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN)"
+MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN) $MAKE_OPTS"
 MAKE_OPTS_OUT_TREE="$MAKE_OPTS -C $BUILD_DIR -f $SRC_DIR/Makefile top_srcdir=$SRC_DIR top_builddir=$BUILD_DIR"
 
 run_configure()