From patchwork Thu Jun 23 08:02:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avinesh Kumar X-Patchwork-Id: 1646924 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BYll4RSP; dkim=fail reason="signature verification failed" header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=L7xiYkRz; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LTCRL3PhQz9sGT for ; Thu, 23 Jun 2022 18:02:54 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9164D3C954D for ; Thu, 23 Jun 2022 10:02:46 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 1A4DC3C94E0 for ; Thu, 23 Jun 2022 10:02:25 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 1EE61200ADF for ; Thu, 23 Jun 2022 10:02:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 943741FD43; Thu, 23 Jun 2022 08:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655971344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cyxq6j1ipDFcdsJVDpXx7hgRh3+yoOIwEgwrg6wX/rY=; b=BYll4RSPZaRlvSUbggPbeg5yyU5tFl113Hra7Eu4K7j6H86YJUqjttFtBRJz/RG3UIX/MX uciZzxt3DFu6MuqDVRJZyJF90W9kxKSjn9rZse5WrYLN8S2S2/mGoPF3ZTncNdkV1HtMBW NMAbSqgvUmag34maB/yQC+RhWcRBI5Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655971344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cyxq6j1ipDFcdsJVDpXx7hgRh3+yoOIwEgwrg6wX/rY=; b=L7xiYkRzxc6TUXyX8iBHuJJMFLaTMWNUFA4eogbUrM4wyhhquDzth97Ls/zFH47an4XS2v 2BLqoG8axmYwHCBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 35499133A6; Thu, 23 Jun 2022 08:02:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6xRzAhAetGJudgAAMHmgww (envelope-from ); Thu, 23 Jun 2022 08:02:24 +0000 From: Avinesh Kumar To: ltp@lists.linux.it Date: Thu, 23 Jun 2022 13:32:11 +0530 Message-Id: <20220623080215.24186-3-akumar@suse.de> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220623080215.24186-1-akumar@suse.de> References: <20220623080215.24186-1-akumar@suse.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on in-7.smtp.seeweb.it Subject: [LTP] [PATCH v2 2/6] Rewrite utime02.c using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Signed-off-by: Avinesh Kumar Reviewed-by: Richard Palethorpe --- testcases/kernel/syscalls/utime/utime02.c | 283 ++++++---------------- 1 file changed, 68 insertions(+), 215 deletions(-) diff --git a/testcases/kernel/syscalls/utime/utime02.c b/testcases/kernel/syscalls/utime/utime02.c index 14d5e18c9..a145370e1 100644 --- a/testcases/kernel/syscalls/utime/utime02.c +++ b/testcases/kernel/syscalls/utime/utime02.c @@ -1,238 +1,91 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* - * * Copyright (c) International Business Machines Corp., 2001 - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See - * the GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + * 07/2001 ported by John George + * Copyright (c) 2022 SUSE LLC Avinesh Kumar */ -/* - * Test Name: utime02 - * - * Test Description: - * Verify that the system call utime() successfully sets the modification - * and access times of a file to the current time, under the following - * constraints, - * - The times argument is null. - * - The user ID of the process is not "root". - * - The file is owned by the user ID of the process. - * - * Expected Result: - * utime succeeds returning zero and sets the access and modification - * times of the file to the current time. - * - * Algorithm: - * Setup: - * Setup signal handling. - * Create temporary directory. - * Pause for SIGUSR1 if option specified. - * - * Test: - * Loop if the proper options are given. - * Execute system call - * Check return code, if system call failed (return=-1) - * Log the errno and Issue a FAIL message. - * Otherwise, - * Verify the Functionality of system call - * if successful, - * Issue Functionality-Pass message. - * Otherwise, - * Issue Functionality-Fail message. - * Cleanup: - * Print errno log and/or timing stats if options given - * Delete the temporary directory created. - * - * Usage: - * utime02 [-c n] [-e] [-f] [-i n] [-I x] [-p x] [-t] - * where, -c n : Run n copies concurrently. - * -e : Turn on errno logging. - * -f : Turn off functionality Testing. - * -i n : Execute test n times. - * -I x : Execute test for x seconds. - * -P x : Pause for x seconds between iterations. - * -t : Turn on syscall timing. - * - * History - * 07/2001 John George - * -Ported - * - * Restrictions: +/*\ + * [Description] * + * Verify that the system call utime() successfully changes the last + * access and modification times of a file to the current time, + * under the following constraints: + * - The times argument is NULL. + * - The user ID of the process is not "root". + * - The file is owned by the user ID of the process. */ -#include -#include -#include -#include -#include #include -#include -#include -#include #include -#include - -#include "test.h" -#include "safe_macros.h" -#define TEMP_FILE "tmp_file" -#define FILE_MODE S_IRUSR | S_IRGRP | S_IROTH +#include "tst_test.h" +#include "tst_clocks.h" -char *TCID = "utime02"; -int TST_TOTAL = 1; -time_t curr_time; /* current time in seconds */ - -char nobody_uid[] = "nobody"; -struct passwd *ltpuser; - -void setup(); /* Main setup function of test */ -void cleanup(); /* cleanup function for the test */ - -int main(int ac, char **av) -{ - struct stat stat_buf; /* struct buffer to hold file info. */ - int lc; - long type; - time_t modf_time, access_time; - time_t pres_time; /* file modification/access/present time */ - - tst_parse_opts(ac, av, NULL, NULL); - - setup(); - - switch ((type = tst_fs_type(cleanup, "."))) { - case TST_NFS_MAGIC: - if (tst_kvercmp(2, 6, 18) < 0) - tst_brkm(TCONF, cleanup, "Cannot do utime on a file" - " on %s filesystem before 2.6.18", - tst_fs_type_name(type)); - break; - case TST_V9FS_MAGIC: - tst_brkm(TCONF, cleanup, - "Cannot do utime on a file on %s filesystem", - tst_fs_type_name(type)); - break; - } +#define MNT_POINT "mntpoint" +#define TEMP_FILE MNT_POINT"/tmp_file" +#define FILE_MODE 0444 - for (lc = 0; TEST_LOOPING(lc); lc++) { - - tst_count = 0; - - /* - * Invoke utime(2) to set TEMP_FILE access and - * modification times to the current time. - */ - TEST(utime(TEMP_FILE, NULL)); - - if (TEST_RETURN == -1) { - tst_resm(TFAIL|TTERRNO, "utime(%s) failed", TEMP_FILE); - } else { - /* - * Sleep for a second so that mod time and - * access times will be different from the - * current time - */ - sleep(2); - - /* - * Get the current time now, after calling - * utime(2) - */ - pres_time = time(NULL); - - /* - * Get the modification and access times of - * temporary file using stat(2). - */ - SAFE_STAT(cleanup, TEMP_FILE, &stat_buf); - modf_time = stat_buf.st_mtime; - access_time = stat_buf.st_atime; - - /* Now do the actual verification */ - if (modf_time <= curr_time || - modf_time >= pres_time || - access_time <= curr_time || - access_time >= pres_time) { - tst_resm(TFAIL, "%s access and " - "modification times not set", - TEMP_FILE); - } else { - tst_resm(TPASS, "Functionality of " - "utime(%s, NULL) successful", - TEMP_FILE); - } - } - tst_count++; - } +#define TEST_USERNAME "nobody" - cleanup(); - tst_exit(); -} -/* - * void - * setup() - performs all ONE TIME setup for this test. - * Create a temporary directory and change directory to it. - * Create a test file under temporary directory and close it - */ -void setup(void) +static void setup(void) { - int fildes; /* file handle for temp file */ - - tst_require_root(); - - tst_sig(FORK, DEF_HANDLER, cleanup); - - /* Switch to nobody user for correct error code collection */ - ltpuser = SAFE_GETPWNAM(NULL, nobody_uid); - SAFE_SETUID(NULL, ltpuser->pw_uid); - - /* Pause if that option was specified - * TEST_PAUSE contains the code to fork the test with the -i option. - * You want to make sure you do this before you create your temporary - * directory. - */ - TEST_PAUSE; + struct passwd *pw; - tst_tmpdir(); + pw = SAFE_GETPWNAM(TEST_USERNAME); - /* Creat a temporary file under above directory */ - fildes = SAFE_CREAT(cleanup, TEMP_FILE, FILE_MODE); + SAFE_TOUCH(TEMP_FILE, FILE_MODE, NULL); + SAFE_CHOWN(TEMP_FILE, pw->pw_uid, pw->pw_gid); - /* Close the temporary file created */ - SAFE_CLOSE(cleanup, fildes); - - /* Get the current time */ - curr_time = time(NULL); - - /* - * Sleep for a second so that mod time and access times will be - * different from the current time - */ - sleep(2); /* sleep(1) on IA64 sometimes sleeps < 1 sec!! */ + tst_res(TINFO, "Switching effective user ID to user: %s", pw->pw_name); + SAFE_SETEUID(pw->pw_uid); } -/* - * void - * cleanup() - performs all ONE TIME cleanup for this test at - * completion or premature exit. - * Remove the test directory and testfile created in the setup. - */ -void cleanup(void) +static void run(void) { - - tst_rmdir(); - + struct utimbuf utbuf; + struct stat stat_buf; + time_t pre_time, post_time; + + utbuf.modtime = tst_get_fs_timestamp() - 5; + utbuf.actime = utbuf.modtime + 1; + TST_EXP_PASS_SILENT(utime(TEMP_FILE, &utbuf)); + SAFE_STAT(TEMP_FILE, &stat_buf); + + TST_EXP_EQ_LI(stat_buf.st_atime, utbuf.actime); + TST_EXP_EQ_LI(stat_buf.st_mtime, utbuf.modtime); + + pre_time = tst_get_fs_timestamp(); + TST_EXP_PASS(utime(TEMP_FILE, NULL), "utime(%s, NULL)", TEMP_FILE); + if (!TST_PASS) + return; + post_time = tst_get_fs_timestamp(); + SAFE_STAT(TEMP_FILE, &stat_buf); + + if (stat_buf.st_mtime < pre_time || stat_buf.st_mtime > post_time) + tst_res(TFAIL, "utime() did not set expected mtime, " + "pre_time: %ld, post_time: %ld, st_mtime: %ld", + pre_time, post_time, stat_buf.st_mtime); + + if (stat_buf.st_atime < pre_time || stat_buf.st_atime > post_time) + tst_res(TFAIL, "utime() did not set expected atime, " + "pre_time: %ld, post_time: %ld, st_atime: %ld", + pre_time, post_time, stat_buf.st_atime); } + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .needs_root = 1, + .needs_tmpdir = 1, + .mntpoint = MNT_POINT, + .mount_device = 1, + .all_filesystems = 1, + .skip_filesystems = (const char *const[]) { + "vfat", + "exfat", + NULL + } +};