| Message ID | 20220520083627.2499121-3-liwang@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | two follow up fix for Introduce-of-max-runtime | expand |
Hi! > As we have removed the "-x" support from this test, there is no way to > reduce running time by multiply small float number. Actually the -x has been replaced by -I so we may as well change the runtest file to pass -I instead. On the other hand I guess that the original runtime was way too long for a default value. > Let's set 10 seconds for the max_runtime (approximately equal to -x 0.002). If we are touching the code we may as well pick slightly longer interval, what about a minute so that we have chance to do some testing even on slower targets? > Signed-off-by: Li Wang <liwang@redhat.com> > --- > runtest/mm | 2 +- > testcases/kernel/mem/mtest06/mmap3.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/runtest/mm b/runtest/mm > index 6537666a9..4ecb61f24 100644 > --- a/runtest/mm > +++ b/runtest/mm > @@ -16,7 +16,7 @@ mtest01w mtest01 -p80 -w > mtest05 mmstress > mtest06 mmap1 > mtest06_2 mmap2 -x 0.002 -a -p > -mtest06_3 mmap3 -x 0.002 -p > +mtest06_3 mmap3 -p > # Remains diabled till the infinite loop problem is solved > #mtest-6_4 shmat1 -x 0.00005 > > diff --git a/testcases/kernel/mem/mtest06/mmap3.c b/testcases/kernel/mem/mtest06/mmap3.c > index 6d47b01e7..3064f5cf7 100644 > --- a/testcases/kernel/mem/mtest06/mmap3.c > +++ b/testcases/kernel/mem/mtest06/mmap3.c > @@ -182,5 +182,5 @@ static struct tst_test test = { > .setup = setup, > .cleanup = cleanup, > .test_all = test_mmap, > - .max_runtime = 86400, > + .max_runtime = 10, > }; > -- > 2.31.1 > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp
On Fri, May 20, 2022 at 7:03 PM Cyril Hrubis <chrubis@suse.cz> wrote: > Hi! > > As we have removed the "-x" support from this test, there is no way to > > reduce running time by multiply small float number. > > Actually the -x has been replaced by -I so we may as well change the > runtest file to pass -I instead. > Good to know, thanks! > > On the other hand I guess that the original runtime was way too long for > a default value. > > > Let's set 10 seconds for the max_runtime (approximately equal to -x > 0.002). > > If we are touching the code we may as well pick slightly longer > interval, what about a minute so that we have chance to do some testing > even on slower targets? > Make sense! Feel free to add your amend when patchset merging, I'd not send V2 to bring additional review work.
diff --git a/runtest/mm b/runtest/mm index 6537666a9..4ecb61f24 100644 --- a/runtest/mm +++ b/runtest/mm @@ -16,7 +16,7 @@ mtest01w mtest01 -p80 -w mtest05 mmstress mtest06 mmap1 mtest06_2 mmap2 -x 0.002 -a -p -mtest06_3 mmap3 -x 0.002 -p +mtest06_3 mmap3 -p # Remains diabled till the infinite loop problem is solved #mtest-6_4 shmat1 -x 0.00005 diff --git a/testcases/kernel/mem/mtest06/mmap3.c b/testcases/kernel/mem/mtest06/mmap3.c index 6d47b01e7..3064f5cf7 100644 --- a/testcases/kernel/mem/mtest06/mmap3.c +++ b/testcases/kernel/mem/mtest06/mmap3.c @@ -182,5 +182,5 @@ static struct tst_test test = { .setup = setup, .cleanup = cleanup, .test_all = test_mmap, - .max_runtime = 86400, + .max_runtime = 10, };
As we have removed the "-x" support from this test, there is no way to reduce running time by multiply small float number. Let's set 10 seconds for the max_runtime (approximately equal to -x 0.002). Signed-off-by: Li Wang <liwang@redhat.com> --- runtest/mm | 2 +- testcases/kernel/mem/mtest06/mmap3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)