| Message ID | 20220216090708.29588-1-blezhepekov@suse.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] ltpfs/main.c: Initialize return variable | expand |
Hi Bogdan, > LTP_fs_open_block_device returned initialized local ^ uninitialized ? > variable, when device handler is occupied. Reviewed-by: Petr Vorel <pvorel@suse.cz> LGTM. Kind regards, Petr
On 2022-02-16 11:26, Petr Vorel wrote: > Hi Bogdan, > >> LTP_fs_open_block_device returned initialized local > ^ uninitialized ? > >> variable, when device handler is occupied. > > Reviewed-by: Petr Vorel <pvorel@suse.cz> > LGTM. > > Kind regards, > Petr Oops, it's a typo. Obviously should be "uninitialized". Want me to submit an update? -Bogdan
Hi Bogdan, > > > LTP_fs_open_block_device returned initialized local > > ^ uninitialized ? > Oops, it's a typo. Obviously should be "uninitialized". > Want me to submit an update? No need, I fixed it before merge. Merged as d66c51d92c. Thanks! Kind regards, Petr
diff --git a/testcases/kernel/fs/scsi/ltpfs/main.c b/testcases/kernel/fs/scsi/ltpfs/main.c index dc3e8f30c..2c67c7a47 100644 --- a/testcases/kernel/fs/scsi/ltpfs/main.c +++ b/testcases/kernel/fs/scsi/ltpfs/main.c @@ -391,7 +391,7 @@ int LTP_fs_open_block_device() { dev_t devt; struct stat statbuf; - int rc; + int rc = 0; if (ltp_block_dev_handle == 0) {
LTP_fs_open_block_device returned initialized local variable, when device handler is occupied. Signed-off-by: Bogdan Lezhepekov <blezhepekov@suse.de> --- testcases/kernel/fs/scsi/ltpfs/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)