| Message ID | 20220211152751.4651-1-bogdan.lezhepekov@suse.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v1] lib/tst_memutils.c: Fix resource leak | expand |
Hi! > diff --git a/lib/tst_memutils.c b/lib/tst_memutils.c > index 4a4974761..2e6d7d5fd 100644 > --- a/lib/tst_memutils.c > +++ b/lib/tst_memutils.c > @@ -122,7 +122,10 @@ static int write_score(const char *path, int score) > return 1; > > if (fprintf(f, "%d", score) <= 0) > + { > + fclose(f); > return 1; > + } The coding style is wrong. Please run 'make check' in the respective directory when the source code located and fix all warnings. > if (fclose(f)) > return 1; > -- > 2.35.1 > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp
diff --git a/lib/tst_memutils.c b/lib/tst_memutils.c index 4a4974761..2e6d7d5fd 100644 --- a/lib/tst_memutils.c +++ b/lib/tst_memutils.c @@ -122,7 +122,10 @@ static int write_score(const char *path, int score) return 1; if (fprintf(f, "%d", score) <= 0) + { + fclose(f); return 1; + } if (fclose(f)) return 1;
File descriptor was not closed properly before return. Signed-off-by: Bogdan Lezhepekov <bogdan.lezhepekov@suse.com> --- lib/tst_memutils.c | 3 +++ 1 file changed, 3 insertions(+)