| Message ID | 20220210111828.39927-1-kushalkataria5@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v3] fstat_02: Increase test coverage by creating hard link to file and validate using fstat | expand |
Hi! > Please ignore patch v2, I think that is wrong. > > Fix format specfiers and cast to correct type when printing. Well either it's %li and cast to (long) or %i and cast to (int) both will work fine in this case. However the points stated in v2 still apply to this patch as well. > Implements: #517 > --- > testcases/kernel/syscalls/fstat/fstat02.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/testcases/kernel/syscalls/fstat/fstat02.c b/testcases/kernel/syscalls/fstat/fstat02.c > index c0229de44..8084cd4c2 100644 > --- a/testcases/kernel/syscalls/fstat/fstat02.c > +++ b/testcases/kernel/syscalls/fstat/fstat02.c > @@ -17,8 +17,10 @@ > #include "tst_safe_macros.h" > > #define TESTFILE "test_file" > +#define LINK_TESTFILE "link_test_file" > #define FILE_SIZE 1024 > #define FILE_MODE 0644 > +#define NLINK 2 > > static struct stat stat_buf; > static uid_t user_id; > @@ -61,6 +63,12 @@ static void run(void) > fail++; > } > > + if (stat_buf.st_nlink != NLINK) { > + tst_res(TFAIL, "stat_buf.st_nlink = %i expected %i", > + (int)stat_buf.st_nlink, NLINK); > + fail++; > + } > + > if (fail) > return; > > @@ -78,6 +86,8 @@ static void setup(void) > > if (tst_fill_file(TESTFILE, 'a', FILE_SIZE, 1)) > tst_brk(TBROK, "Could not fill Testfile!"); > + > + SAFE_LINK(TESTFILE, LINK_TESTFILE); > } > > static void cleanup(void) > -- > 2.25.1 > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp
diff --git a/testcases/kernel/syscalls/fstat/fstat02.c b/testcases/kernel/syscalls/fstat/fstat02.c index c0229de44..8084cd4c2 100644 --- a/testcases/kernel/syscalls/fstat/fstat02.c +++ b/testcases/kernel/syscalls/fstat/fstat02.c @@ -17,8 +17,10 @@ #include "tst_safe_macros.h" #define TESTFILE "test_file" +#define LINK_TESTFILE "link_test_file" #define FILE_SIZE 1024 #define FILE_MODE 0644 +#define NLINK 2 static struct stat stat_buf; static uid_t user_id; @@ -61,6 +63,12 @@ static void run(void) fail++; } + if (stat_buf.st_nlink != NLINK) { + tst_res(TFAIL, "stat_buf.st_nlink = %i expected %i", + (int)stat_buf.st_nlink, NLINK); + fail++; + } + if (fail) return; @@ -78,6 +86,8 @@ static void setup(void) if (tst_fill_file(TESTFILE, 'a', FILE_SIZE, 1)) tst_brk(TBROK, "Could not fill Testfile!"); + + SAFE_LINK(TESTFILE, LINK_TESTFILE); } static void cleanup(void)