| Message ID | 20220125025008.xlnm3uwafi4dvaun@xzhoux.usersys.redhat.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2] include/mk/env_pre.mk: remove dup makefile sourcing | expand |
Hi Murphy, > This will cause file not found errors. ... > +++ b/include/mk/env_pre.mk > @@ -88,9 +88,6 @@ endif > # autotools, *clean, and help don't require config.mk, features.mk, etc... > ifeq ($(filter autotools %clean .gitignore gitignore.% help,$(MAKECMDGOALS)),) > -include $(abs_top_builddir)/include/mk/config.mk > -include $(abs_top_builddir)/include/mk/features.mk > - This is most certainly wrong, these includes are needed. I guess you run make without running: make autotools && ./configure https://github.com/linux-test-project/ltp#quick-guide-to-running-the-tests Kind regards, Petr
diff --git a/include/mk/env_pre.mk b/include/mk/env_pre.mk index f36215167..f913eb5fd 100644 --- a/include/mk/env_pre.mk +++ b/include/mk/env_pre.mk @@ -88,9 +88,6 @@ endif # autotools, *clean, and help don't require config.mk, features.mk, etc... ifeq ($(filter autotools %clean .gitignore gitignore.% help,$(MAKECMDGOALS)),) -include $(abs_top_builddir)/include/mk/config.mk -include $(abs_top_builddir)/include/mk/features.mk - # START out-of-build-tree check. ifneq ($(abs_builddir),$(abs_srcdir)) BUILD_TREE_STATE := $(BUILD_TREE_BUILDDIR_INSTALL)
This will cause file not found errors. Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> --- v2: fix sign-off mail address include/mk/env_pre.mk | 3 --- 1 file changed, 3 deletions(-)