| Message ID | 20220121150111.22995-1-andrea.cervesato@suse.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] Reduce default children in dio_read test | expand |
Hi Andrea,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
So we don't have to use .timeout for it.
Thanks!
Kind regards,
Petr
Hi, Acked-by: Martin Doucha <mdoucha@suse.cz> On 21. 01. 22 16:01, Andrea Cervesato wrote: > We reduce default children from 100 to 8 in order to reduce time > execution and memory footprint consuption when using default > values. > > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.de> > --- > testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/testcases/kernel/io/ltp-aiodio/dio_read.c b/testcases/kernel/io/ltp-aiodio/dio_read.c > index 2c2ec4bce..b0bbb25d5 100644 > --- a/testcases/kernel/io/ltp-aiodio/dio_read.c > +++ b/testcases/kernel/io/ltp-aiodio/dio_read.c > @@ -26,7 +26,7 @@ static char *str_readsize; > static char *str_filesize; > > static char *filename = "file.bin"; > -static int numchildren = 100; > +static int numchildren = 8; > static long long writesize = 32 * 1024 * 1024; > static long long readsize = 32 * 1024 * 1024; > static long long filesize = 128 * 1024 * 1024; > @@ -171,7 +171,7 @@ static struct tst_test test = { > .needs_tmpdir = 1, > .forks_child = 1, > .options = (struct tst_option[]) { > - {"n:", &str_numchildren, "Number of threads (default 100)"}, > + {"n:", &str_numchildren, "Number of threads (default 8)"}, > {"w:", &str_writesize, "Size of writing blocks (default 32M)"}, > {"r:", &str_readsize, "Size of reading blocks (default 32M)"}, > {"s:", &str_filesize, "File size (default 128M)"},
diff --git a/testcases/kernel/io/ltp-aiodio/dio_read.c b/testcases/kernel/io/ltp-aiodio/dio_read.c index 2c2ec4bce..b0bbb25d5 100644 --- a/testcases/kernel/io/ltp-aiodio/dio_read.c +++ b/testcases/kernel/io/ltp-aiodio/dio_read.c @@ -26,7 +26,7 @@ static char *str_readsize; static char *str_filesize; static char *filename = "file.bin"; -static int numchildren = 100; +static int numchildren = 8; static long long writesize = 32 * 1024 * 1024; static long long readsize = 32 * 1024 * 1024; static long long filesize = 128 * 1024 * 1024; @@ -171,7 +171,7 @@ static struct tst_test test = { .needs_tmpdir = 1, .forks_child = 1, .options = (struct tst_option[]) { - {"n:", &str_numchildren, "Number of threads (default 100)"}, + {"n:", &str_numchildren, "Number of threads (default 8)"}, {"w:", &str_writesize, "Size of writing blocks (default 32M)"}, {"r:", &str_readsize, "Size of reading blocks (default 32M)"}, {"s:", &str_filesize, "File size (default 128M)"},
We reduce default children from 100 to 8 in order to reduce time execution and memory footprint consuption when using default values. Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.de> --- testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)