diff mbox series

syscalls/inotify_init: Add cleanup() before exit

Message ID 20211125022735.152073-1-zhaogongyi@huawei.com
State Changes Requested
Headers show
Series syscalls/inotify_init: Add cleanup() before exit | expand

Commit Message

Zhao Gongyi Nov. 25, 2021, 2:27 a.m. UTC 
For inotify_init1_01/inotify_init1_02, Add cleanup() before exit.

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
 testcases/kernel/syscalls/inotify_init/inotify_init1_01.c | 2 +-
 testcases/kernel/syscalls/inotify_init/inotify_init1_02.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

--
2.17.1

Comments

Petr Vorel Jan. 27, 2022, 2:11 p.m. UTC | #1 
Hi Zhao,

> For inotify_init1_01/inotify_init1_02, Add cleanup() before exit.
While this is correct, how about rewriting tests to use new C API?

https://github.com/linux-test-project/ltp/wiki/C-Test-API

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/inotify_init/inotify_init1_01.c b/testcases/kernel/syscalls/inotify_init/inotify_init1_01.c
index f1203a495..2c497492b 100644
--- a/testcases/kernel/syscalls/inotify_init/inotify_init1_01.c
+++ b/testcases/kernel/syscalls/inotify_init/inotify_init1_01.c
@@ -171,6 +171,6 @@  int main(int argc, char *argv[])
 			}
 		}
 	}
-	tst_exit();
 	cleanup();
+	tst_exit();
 }
diff --git a/testcases/kernel/syscalls/inotify_init/inotify_init1_02.c b/testcases/kernel/syscalls/inotify_init/inotify_init1_02.c
index b074214f7..3fa85644d 100644
--- a/testcases/kernel/syscalls/inotify_init/inotify_init1_02.c
+++ b/testcases/kernel/syscalls/inotify_init/inotify_init1_02.c
@@ -169,5 +169,6 @@  int main(int argc, char *argv[])
 			tst_resm(TPASS, "inotify_init1(IN_NONBLOCK) PASSED");
 		}
 	}
+	cleanup();
 	tst_exit();
 }