| Message ID | 20211119074602.857595-7-lkml@jv-coder.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Fix or suppress compiler warnings in posix/conformance/interfaces | expand |
Hi! Applied, thanks.
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstack/6-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstack/6-1.c index 5eac212f9..d298c30ec 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstack/6-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstack/6-1.c @@ -31,12 +31,6 @@ static void *stack_addr; static size_t stack_size; -static void *thread_func() -{ - pthread_exit(0); - return NULL; -} - int main(void) { pthread_attr_t attr; diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstack/7-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstack/7-1.c index bc7f4f415..932fa8200 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstack/7-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstack/7-1.c @@ -32,12 +32,6 @@ static void *stack_addr; static size_t stack_size; -static void *thread_func() -{ - pthread_exit(0); - return NULL; -} - int main(void) { pthread_attr_t attr; diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstacksize/4-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstacksize/4-1.c index b229d7052..800913a66 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstacksize/4-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstacksize/4-1.c @@ -28,12 +28,6 @@ #define STACKSIZE PTHREAD_STACK_MIN - sysconf(_SC_PAGE_SIZE) -static void *thread_func() -{ - pthread_exit(0); - return NULL; -} - int main(void) { pthread_attr_t attr; diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/4-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/4-1.c index 1252d5619..810df0c34 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/4-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/4-1.c @@ -91,12 +91,7 @@ static int global = 0; -/* atexit() routines */ -static void at1(void) -{ - global +=1; -} - +/* atexit() routine */ static void at2(void) { global +=2; @@ -107,7 +102,7 @@ static void *threaded(void *arg PTS_ATTRIBUTE_UNUSED) { int ret = 0; - /* Note that this funtion will be registered once again for each scenario. + /* Note that this function will be registered once again for each scenario. POSIX requires the ability to register at least 32 functions so it should not be an issue in our case, as long as we don't get more than 32 scenarii (with joinable threads) */ diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/5-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/5-1.c index 730b751eb..69d5c6a97 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/5-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_exit/5-1.c @@ -91,12 +91,7 @@ static int atctl = 0; static pthread_key_t tld[3]; -/* atexit() routines */ -static void at1(void) -{ - atctl += 1; -} - +/* atexit() routine */ static void at2(void) { atctl += 2; diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/8-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/8-1.c index 086a0cf5c..b61a08173 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/8-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/8-1.c @@ -153,14 +153,6 @@ static void sighdl2(int sig PTS_ATTRIBUTE_UNUSED) #endif } -static int init_ctl; -/* Init function */ -static void initializer(void) -{ - init_ctl++; - return; -} - /* Test function -- calls pthread_kill() and checks that EINTR is never returned. */ static void *test(void *arg PTS_ATTRIBUTE_UNUSED) { diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/1-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/1-1.c index 913251914..4fccbfdf4 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/1-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_lock/1-1.c @@ -36,7 +36,7 @@ static int value; /* value protected by mutex */ int main(void) { - int i, rc; + int i; pthread_attr_t pta; pthread_t threads[THREAD_NUM]; //pthread_t self = pthread_self(); @@ -47,7 +47,7 @@ int main(void) /* Create threads */ fprintf(stderr, "Creating %d threads\n", THREAD_NUM); for (i = 0; i < THREAD_NUM; ++i) - rc = pthread_create(&threads[i], &pta, f1, NULL); + pthread_create(&threads[i], &pta, f1, NULL); /* Wait to join all threads */ for (i = 0; i < THREAD_NUM; ++i) diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_sigmask/18-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_sigmask/18-1.c index 81ba4ea9b..5801e0e60 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_sigmask/18-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_sigmask/18-1.c @@ -153,14 +153,6 @@ static void sighdl2(int sig PTS_ATTRIBUTE_UNUSED) #endif } -static int init_ctl; -/* Init function */ -static void initializer(void) -{ - init_ctl++; - return; -} - /* Test function -- calls pthread_sigmask() and checks that EINTR is never returned. */ static void *test(void *arg PTS_ATTRIBUTE_UNUSED) {